Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 10190024: Use our own isolate instead of the default one (Closed)
Patch Set: Created April 17, 2013, 1:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -54,24 +54,35 @@ namespace AdblockPlus
{
return webRequest;
}
inline ErrorCallback& GetErrorCallback()
{
return errorCallback;
}
+ class IsolateSetter
Felix Dahlke 2013/04/18 12:16:11 Not entirely happy with IsolateSetter as a name, b
+ {
+ public:
+ IsolateSetter(v8::Isolate* isolate);
+ virtual ~IsolateSetter();
Felix Dahlke 2013/04/18 12:16:11 Since this is not a base class, the destructor sho
+
+ private:
+ v8::Isolate* isolate;
+ };
+
class Context
{
public:
Context(const JsEngine& jsEngine);
- virtual inline ~Context() {};
+ virtual ~Context() {}
Felix Dahlke 2013/04/18 12:16:11 Since Context is not being inherited from what I s
private:
const v8::Locker locker;
+ const IsolateSetter isolateSetter;
const v8::HandleScope handleScope;
const v8::Context::Scope contextScope;
};
private:
FileSystem& fileSystem;
WebRequest& webRequest;
ErrorCallback& errorCallback;
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld