Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/compat.js

Issue 10213003: Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily (Closed)
Left Patch Set: Added tests, resolved type conversion ambiguities, implemented some missing API calls Created April 15, 2013, 6:23 a.m.
Right Patch Set: Addressed review comments Created April 17, 2013, 7:56 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/api.js ('k') | libadblockplus.gyp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of the Adblock Plus extension, 2 * This file is part of the Adblock Plus extension,
3 * Copyright (C) 2006-2012 Eyeo GmbH 3 * Copyright (C) 2006-2012 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 // TODO: These need to be defined properly 18 // TODO: These need to be defined properly
19 var window = this; 19 var window = this;
20 function XMLHttpRequest() {}; 20 function XMLHttpRequest() {};
21 function requestFileSystem() {};
22 21
23 // 22 //
24 // Module framework stuff 23 // Module framework stuff
25 // 24 //
26 25
27 function require(module) 26 function require(module)
28 { 27 {
29 return require.scopes[module]; 28 return require.scopes[module];
30 } 29 }
31 require.scopes = {__proto__: null}; 30 require.scopes = {__proto__: null};
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 status: -1, 285 status: -1,
287 notificationCallbacks: {}, 286 notificationCallbacks: {},
288 loadFlags: 0, 287 loadFlags: 0,
289 INHIBIT_CACHING: 0, 288 INHIBIT_CACHING: 0,
290 VALIDATE_ALWAYS: 0, 289 VALIDATE_ALWAYS: 0,
291 QueryInterface: function() 290 QueryInterface: function()
292 { 291 {
293 return this; 292 return this;
294 } 293 }
295 }; 294 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld