Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus.gyp

Issue 10213003: Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily (Closed)
Left Patch Set: Added tests, resolved type conversion ambiguities, implemented some missing API calls Created April 15, 2013, 6:23 a.m.
Right Patch Set: Addressed review comments Created April 17, 2013, 7:56 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/compat.js ('k') | src/FilterEngine.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'variables': { 2 'variables': {
3 'have_curl': '<!(python check_curl.py)' 3 'have_curl': '<!(python check_curl.py)'
4 }, 4 },
5 'includes': ['third_party/v8/build/common.gypi', 5 'includes': ['third_party/v8/build/common.gypi',
6 'shell/shell.gyp'], 6 'shell/shell.gyp'],
7 'targets': [{ 7 'targets': [{
8 'target_name': 'libadblockplus', 8 'target_name': 'libadblockplus',
9 'type': '<(library)', 9 'type': '<(library)',
10 'include_dirs': [ 10 'include_dirs': [
11 'include', 11 'include',
12 'third_party/v8/include' 12 'third_party/v8/include'
13 ], 13 ],
14 'defines': ['FILTER_ENGINE_STUBS=0'], 14 'defines': ['FILTER_ENGINE_STUBS=0'],
15 'all_dependent_settings': { 15 'all_dependent_settings': {
16 'defines': ['FILTER_ENGINE_STUBS=0'] 16 'defines': ['FILTER_ENGINE_STUBS=0']
17 }, 17 },
18 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'], 18 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'],
19 'sources': [ 19 'sources': [
20 'src/ConsoleJsObject.cpp', 20 'src/ConsoleJsObject.cpp',
21 'src/DefaultFileSystem.cpp',
21 'src/ErrorCallback.cpp', 22 'src/ErrorCallback.cpp',
22 'src/FileReader.cpp', 23 'src/FileSystemJsObject.cpp',
23 'src/FilterEngine.cpp', 24 'src/FilterEngine.cpp',
24 'src/GlobalJsObject.cpp', 25 'src/GlobalJsObject.cpp',
25 'src/JsEngine.cpp', 26 'src/JsEngine.cpp',
26 'src/JsValue.cpp', 27 'src/JsValue.cpp',
27 'src/Thread.cpp', 28 'src/Thread.cpp',
29 'src/Utils.cpp',
28 'src/WebRequestJsObject.cpp', 30 'src/WebRequestJsObject.cpp',
29 '<(INTERMEDIATE_DIR)/adblockplus.js.cc' 31 '<(INTERMEDIATE_DIR)/adblockplus.js.cc'
30 ], 32 ],
31 'direct_dependent_settings': { 33 'direct_dependent_settings': {
32 'include_dirs': ['include'] 34 'include_dirs': ['include']
33 }, 35 },
34 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'], 36 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'],
35 'conditions': [ 37 'conditions': [
36 ['have_curl==1', 38 ['have_curl==1',
37 { 39 {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 }, 100 },
99 { 101 {
100 'target_name': 'tests', 102 'target_name': 'tests',
101 'type': 'executable', 103 'type': 'executable',
102 'dependencies': [ 104 'dependencies': [
103 'third_party/googletest.gyp:googletest_main', 105 'third_party/googletest.gyp:googletest_main',
104 'libadblockplus' 106 'libadblockplus'
105 ], 107 ],
106 'sources': [ 108 'sources': [
107 'test/ConsoleJsObject.cpp', 109 'test/ConsoleJsObject.cpp',
110 'test/DefaultFileSystem.cpp',
111 'test/FileSystemJsObject.cpp',
108 'test/FilterEngineStubs.cpp', 112 'test/FilterEngineStubs.cpp',
109 'test/GlobalJsObject.cpp', 113 'test/GlobalJsObject.cpp',
110 'test/JsEngine.cpp', 114 'test/JsEngine.cpp',
111 'test/JsValue.cpp', 115 'test/JsValue.cpp',
112 'test/Thread.cpp', 116 'test/Thread.cpp',
113 'test/WebRequest.cpp' 117 'test/WebRequest.cpp'
114 ] 118 ]
115 }] 119 }]
116 } 120 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld