Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus.gyp

Issue 10234088: Use GYP to generate MSVS project files (Closed)
Left Patch Set: Created April 23, 2013, 4:24 p.m.
Right Patch Set: Moved project files to build/ Created April 24, 2013, 1:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 { 1 {
2 'conditions': [[ 2 'conditions': [[
3 # We don't want to use curl on Windows, skip the check there 3 # We don't want to use curl on Windows, skip the check there
4 'OS=="win"', 4 'OS=="win"',
5 { 5 {
6 'variables': { 6 'variables': {
7 'have_curl': 0 7 'have_curl': 0
8 } 8 }
9 }, 9 },
10 { 10 {
(...skipping 19 matching lines...) Expand all
30 'src/DefaultFileSystem.cpp', 30 'src/DefaultFileSystem.cpp',
31 'src/ErrorCallback.cpp', 31 'src/ErrorCallback.cpp',
32 'src/FileSystemJsObject.cpp', 32 'src/FileSystemJsObject.cpp',
33 'src/FilterEngine.cpp', 33 'src/FilterEngine.cpp',
34 'src/GlobalJsObject.cpp', 34 'src/GlobalJsObject.cpp',
35 'src/JsEngine.cpp', 35 'src/JsEngine.cpp',
36 'src/JsValue.cpp', 36 'src/JsValue.cpp',
37 'src/Thread.cpp', 37 'src/Thread.cpp',
38 'src/Utils.cpp', 38 'src/Utils.cpp',
39 'src/WebRequestJsObject.cpp', 39 'src/WebRequestJsObject.cpp',
40 '<(INTERMEDIATE_DIR)/adblockplus.js.cpp' 40 '<(INTERMEDIATE_DIR)/adblockplus.js.cpp'
Eric 2013/04/23 17:12:17 I had this as SHARED_INTERMEDIATE_DIRECTORY becaus
Wladimir Palant 2013/04/24 06:01:34 I'm not really convinced that this is a good idea
Eric 2013/04/24 13:09:44 If it's specific to a particular target, it should
Wladimir Palant 2013/04/24 14:04:34 From gyp documentation: "INTERMEDIATE_DIR is only
Eric 2013/04/24 14:21:56 That's what I get for inferring behavior only from
41 ], 41 ],
42 'direct_dependent_settings': { 42 'direct_dependent_settings': {
43 'include_dirs': ['include'] 43 'include_dirs': ['include']
44 }, 44 },
45 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'], 45 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'],
46 'conditions': [ 46 'conditions': [
47 ['have_curl==1', 47 ['have_curl==1',
48 { 48 {
49 'sources': [ 49 'sources': [
50 'src/DefaultWebRequestCurl.cpp', 50 'src/DefaultWebRequestCurl.cpp',
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 'test/AppInfoJsObject.cpp', 131 'test/AppInfoJsObject.cpp',
132 'test/ConsoleJsObject.cpp', 132 'test/ConsoleJsObject.cpp',
133 'test/DefaultFileSystem.cpp', 133 'test/DefaultFileSystem.cpp',
134 'test/FileSystemJsObject.cpp', 134 'test/FileSystemJsObject.cpp',
135 'test/FilterEngine.cpp', 135 'test/FilterEngine.cpp',
136 'test/GlobalJsObject.cpp', 136 'test/GlobalJsObject.cpp',
137 'test/JsEngine.cpp', 137 'test/JsEngine.cpp',
138 'test/JsValue.cpp', 138 'test/JsValue.cpp',
139 'test/Thread.cpp', 139 'test/Thread.cpp',
140 'test/WebRequest.cpp' 140 'test/WebRequest.cpp'
141 ] 141 ],
142 'msvs_settings': {
143 'VCLinkerTool': {
144 'SubSystem': '1', # Console
145 'EntryPointSymbol': 'mainCRTStartup',
146 },
147 },
142 }] 148 }]
143 } 149 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld