src/WebRequest.cpp - Issue 10259001: XMLHttpRequest API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/WebRequest.cpp

Issue 10259001: XMLHttpRequest API (Closed)

Patch Set: Created April 10, 2013, 3:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #include <AdblockPlus/WebRequest.h>

	2

	3 AdblockPlus::WebRequest::~WebRequest()
	Felix Dahlke 2013/04/11 09:33:42 I know I've done it like this all the time, but I I know I've done it like this all the time, but I think we should define the virtual destructor of interfaces inline in the future. I'm a fan of keeping definitions out of header files, but I think this is an exception worth making. This is one of the refactorings I'm planning to do, actually. Wladimir Palant 2013/04/11 16:32:33 As you wish. I'll keep this file around however be Show quoted text On 2013/04/11 09:33:42, Felix H. Dahlke wrote: > I know I've done it like this all the time, but I think we should define the > virtual destructor of interfaces inline in the future. I'm a fan of keeping > definitions out of header files, but I think this is an exception worth making. > This is one of the refactorings I'm planning to do, actually. As you wish. I'll keep this file around however because I have a follow-up patch adding to it.
	4 {

	5 }

OLD	NEW