Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus.gyp

Issue 10259001: XMLHttpRequest API (Closed)
Left Patch Set: Created April 10, 2013, 3:19 p.m.
Right Patch Set: Addressed review comments Created April 11, 2013, 4:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/WebRequest.h ('k') | shell/src/Main.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['third_party/v8/build/common.gypi', 2 'includes': ['third_party/v8/build/common.gypi',
3 'shell/shell.gyp'], 3 'shell/shell.gyp'],
4 'targets': [{ 4 'targets': [{
5 'target_name': 'libadblockplus', 5 'target_name': 'libadblockplus',
6 'type': '<(library)', 6 'type': '<(library)',
7 'include_dirs': [ 7 'include_dirs': [
8 'include', 8 'include',
9 'third_party/v8/include' 9 'third_party/v8/include'
10 ], 10 ],
11 'defines': ['FILTER_ENGINE_STUBS=1'], 11 'defines': ['FILTER_ENGINE_STUBS=1'],
12 'all_dependent_settings': {
13 'defines': ['FILTER_ENGINE_STUBS=1']
14 },
12 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'], 15 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'],
13 'sources': [ 16 'sources': [
14 'src/ConsoleJsObject.cpp', 17 'src/ConsoleJsObject.cpp',
15 'src/ErrorCallback.cpp', 18 'src/ErrorCallback.cpp',
16 'src/FileReader.cpp', 19 'src/FileReader.cpp',
17 'src/FilterEngine.cpp', 20 'src/FilterEngine.cpp',
18 'src/GlobalJsObject.cpp', 21 'src/GlobalJsObject.cpp',
19 'src/JsEngine.cpp', 22 'src/JsEngine.cpp',
20 'src/Thread.cpp', 23 'src/Thread.cpp',
21 'src/WebRequest.cpp', 24 'src/WebRequest.cpp',
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 '<@(core_library_files)', 65 '<@(core_library_files)',
63 '--', 66 '--',
64 '<@(additional_library_files)', 67 '<@(additional_library_files)',
65 '<@(_outputs)', 68 '<@(_outputs)',
66 ] 69 ]
67 }] 70 }]
68 }, 71 },
69 { 72 {
70 'target_name': 'tests', 73 'target_name': 'tests',
71 'type': 'executable', 74 'type': 'executable',
72 'defines': ['FILTER_ENGINE_STUBS=1'],
73 'dependencies': [ 75 'dependencies': [
74 'third_party/googletest.gyp:googletest_main', 76 'third_party/googletest.gyp:googletest_main',
75 'libadblockplus' 77 'libadblockplus'
76 ], 78 ],
77 'sources': [ 79 'sources': [
78 'test/ConsoleJsObject.cpp', 80 'test/ConsoleJsObject.cpp',
79 'test/FilterEngineStubs.cpp', 81 'test/FilterEngineStubs.cpp',
80 'test/GlobalJsObject.cpp', 82 'test/GlobalJsObject.cpp',
81 'test/JsEngine.cpp', 83 'test/JsEngine.cpp',
82 'test/Thread.cpp', 84 'test/Thread.cpp',
83 'test/WebRequest.cpp' 85 'test/WebRequest.cpp'
84 ] 86 ]
85 }] 87 }]
86 } 88 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld