Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/WebRequest.h

Issue 10259001: XMLHttpRequest API (Closed)
Patch Set: Created April 10, 2013, 3:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/WebRequest.h
===================================================================
new file mode 100644
--- /dev/null
+++ b/include/AdblockPlus/WebRequest.h
@@ -0,0 +1,26 @@
+#ifndef ADBLOCKPLUS_WEB_REQUEST_H
+#define ADBLOCKPLUS_WEB_REQUEST_H
Felix Dahlke 2013/04/11 09:33:42 We usually have ADBLOCK_PLUS (with an underscore)
Wladimir Palant 2013/04/11 16:32:33 You better check that again, all include files hav
Felix Dahlke 2013/04/11 17:39:28 No, not really. Just the one in Thread.h for some
+
+#include <string>
+#include <vector>
+
+namespace AdblockPlus
+{
+ typedef std::vector< std::pair<std::string, std::string> > HeadersList;
Felix Dahlke 2013/04/11 09:33:42 We usually only have whitespace between >/< if it'
Wladimir Palant 2013/04/11 16:32:33 I prefer proper grouping as done here. Seeing the
+
+ struct ServerResponse
+ {
+ HeadersList responseHeaders;
Felix Dahlke 2013/04/11 09:33:42 How about "Headers" or "HeaderList"? I prefer the
+ int responseStatus;
+ std::string responseText;
+ };
+
+ class WebRequest
+ {
+ public:
+ virtual ~WebRequest();
+ virtual ServerResponse GET(const std::string& url, const HeadersList& requestHeaders) const = 0;
+ };
+}
+
+#endif
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | libadblockplus.gyp » ('j') | src/GlobalJsObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld