Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 10296001: Implement File API (Closed)
Patch Set: Don't pass a blog to _fileSystem.write Created April 12, 2013, 12:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -7,9 +7,9 @@
namespace AdblockPlus
{
+ class FileSystem;
+ class WebRequest;
class ErrorCallback;
- class FileReader;
- class WebRequest;
class JsError : public std::runtime_error
{
@@ -21,7 +21,7 @@
class JsEngine
{
public:
- JsEngine(const FileReader* const fileReader,
+ JsEngine(FileSystem* const fileReader,
WebRequest* const webRequest,
ErrorCallback* const errorCallback);
std::string Evaluate(const std::string& source,
@@ -30,7 +30,7 @@
void Gc();
private:
- const FileReader* const fileReader;
+ const FileSystem* const fileSystem;
Wladimir Palant 2013/04/12 16:10:35 Do we still need that variable? It's only being us
Felix Dahlke 2013/04/15 03:43:34 Wasn't aware that Load was unused. Yeah, we should
v8::Persistent<v8::Context> context;
};
}

Powered by Google App Engine
This is Rietveld