File system path resolving

src/DefaultFileSystem.cpp

 #include <AdblockPlus/DefaultFileSystem.h>
 #include <cstdio>
 #include <cstring>
 #include <fstream>
 #include <stdexcept>
 
 #include <cerrno>
 #include <sys/types.h>
 #include <sys/stat.h>
 
 #ifdef _WIN32
 #ifndef S_ISDIR
 #define S_ISDIR(mode)  (((mode) & S_IFMT) == S_IFDIR)
+#include <Shlobj.h>
 #endif
 
 #ifndef S_ISREG
 #define S_ISREG(mode)  (((mode) & S_IFMT) == S_IFREG)
 #endif
 #endif
 
 #include "../src/Utils.h"
 
 using namespace AdblockPlus;
@@ skipping 50 matching lines @@
       return FileSystem::StatResult();
     throw RuntimeErrorWithErrno("Unable to stat " + path);
   }
   FileSystem::StatResult result;
   result.exists = true;
   result.isFile = S_ISREG(nativeStat.st_mode);
   result.isDirectory = S_ISDIR(nativeStat.st_mode);
   result.lastModified = static_cast<int64_t>(nativeStat.st_mtime) * 1000;
   return result;
 }
+
+std::string DefaultFileSystem::Resolve(const std::string& path) const
+{
+#ifdef WIN32
+  // Resolve to LocalLow folder
+  wchar_t* resolvedPath;
+  HRESULT hr = SHGetKnownFolderPath(FOLDERID_LocalAppDataLow, 0, NULL, &resolvedPath);
+  if (FAILED(hr))
+    return std::string(path);

[Wladimir Palant, 2013/04/24 09:17:35]

Why not just return path; here?

+  std::wstring resolvedW(resolvedPath);
+  CoTaskMemFree(resolvedPath);
+
+  // TODO: Better conversion here
+  std::string resolved(resolvedW.begin(), resolvedW.end());

[Wladimir Palant, 2013/04/24 09:17:35]

Please use Utils::ToUTF8String() here (and we are currently going to be in
trouble either way if we have Unicode characters in the path).

+  resolved.append("\\AdblockPlus\\");
+  resolved.append(path);
+  return resolved;
+#else
+  return std::string(path);

[Wladimir Palant, 2013/04/24 09:17:35]

Why not just return path; here?

+#endif
+}
+