Make sure to work properly with Unicode paths on Windows

src/DefaultFileSystem.cpp

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 28 matching lines @@
 namespace
 {
   class RuntimeErrorWithErrno : public std::runtime_error
   {
   public:
     explicit RuntimeErrorWithErrno(const std::string& message)
       : std::runtime_error(message + " (" + strerror(errno) + ")")
     {
     }
   };
+
+#ifdef WIN32
+  // Paths need to be converted from UTF-8 to UTF-16 on Windows.
+  std::wstring NormalizePath(const std::string& path)
+  {
+    return Utils::ToUTF16String(path, path.length());
+  }
+
+  #define rename _wrename
+  #define remove _wremove
+#else
+  // POSIX systems: assume that file system encoding is UTF-8 and just use the
+  // file paths as they are.
+  #define NormalizePath(path) (path)

[Felix Dahlke, 2013/05/17 09:38:14]

Would rather see a function here, macros can cause all kinds of trouble and are
best avoided in C++. The compiler will inline it all the same.

+#endif
 }
 
 std::tr1::shared_ptr<std::istream>
 DefaultFileSystem::Read(const std::string& path) const
 {
-  return std::tr1::shared_ptr<std::istream>(new std::ifstream(path.c_str()));
+  return std::tr1::shared_ptr<std::istream>(new std::ifstream(NormalizePath(path).c_str()));
 }
 
 void DefaultFileSystem::Write(const std::string& path,
                               std::tr1::shared_ptr<std::ostream> data)
 {
-  std::ofstream file(path.c_str());
+  std::ofstream file(NormalizePath(path).c_str());
   file << Utils::Slurp(*data);
 }
 
 void DefaultFileSystem::Move(const std::string& fromPath,
                              const std::string& toPath)
 {
-  if (rename(fromPath.c_str(), toPath.c_str()))
+  if (rename(NormalizePath(fromPath).c_str(), NormalizePath(toPath).c_str()))
     throw RuntimeErrorWithErrno("Failed to move " + fromPath + " to " + toPath);
 }
 
 void DefaultFileSystem::Remove(const std::string& path)
 {
-  if (remove(path.c_str()))
+  if (remove(NormalizePath(path).c_str()))
     throw RuntimeErrorWithErrno("Failed to remove " + path);
 }
 
 FileSystem::StatResult DefaultFileSystem::Stat(const std::string& path) const
 {
   FileSystem::StatResult result;
 #ifdef WIN32
   WIN32_FILE_ATTRIBUTE_DATA data;
-  std::wstring wpath = Utils::ToUTF16String(path, path.length());
-  if (!GetFileAttributesExW(wpath.c_str(), GetFileExInfoStandard, &data))
+  if (!GetFileAttributesExW(NormalizePath(path).c_str(), GetFileExInfoStandard, &data))
   {
     DWORD err = GetLastError();
     if (err == ERROR_FILE_NOT_FOUND || ERROR_PATH_NOT_FOUND || ERROR_INVALID_DRIVE)
       return result;
     throw RuntimeErrorWithErrno("Unable to stat " + path);
   }
 
   result.exists = true;
   if (data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
   {
@@ skipping 10 matching lines @@
   #define FILE_TIME_TO_UNIX_EPOCH_OFFSET 116444736000000000LL
   #define FILE_TIME_TO_MILLISECONDS_FACTOR 10000
   ULARGE_INTEGER time;
   time.LowPart = data.ftLastWriteTime.dwLowDateTime;
   time.HighPart = data.ftLastWriteTime.dwHighDateTime;
   result.lastModified = (time.QuadPart - FILE_TIME_TO_UNIX_EPOCH_OFFSET) /
       FILE_TIME_TO_MILLISECONDS_FACTOR;
   return result;
 #else
   struct stat nativeStat;
-  const int failure = stat(path.c_str(), &nativeStat);
+  const int failure = stat(NormalizePath(path).c_str(), &nativeStat);
   if (failure)
   {
     if (errno == ENOENT)
       return result;
     throw RuntimeErrorWithErrno("Unable to stat " + path);
   }
   result.exists = true;
   result.isFile = S_ISREG(nativeStat.st_mode);
   result.isDirectory = S_ISDIR(nativeStat.st_mode);
 
@@ skipping 38 matching lines @@
 void DefaultFileSystem::SetBasePath(const std::string& path)
 {
   basePath = path;
 
   if ((*basePath.rbegin() == PATH_SEPARATOR))
   {
     basePath.resize(basePath.size() - 1);
   }
 }