Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: common.gypi

Issue 10488022: Added Android build target (Closed)
Left Patch Set: Created May 16, 2013, 10:23 a.m.
Right Patch Set: Review comments addressed Created May 24, 2013, 8:40 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « Makefile ('k') | libadblockplus.gyp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'variables': { 2 'variables': {
3 'visibility%': 'hidden', 3 'visibility%': 'hidden',
4 'library%': 'static_library', 4 'library%': 'static_library',
5 'component%': '', 5 'component%': '',
6 'want_separate_host_toolset': 0, 6 'want_separate_host_toolset': 0,
7 }, 7 },
8 8
9 'conditions': [ 9 'conditions': [
10 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 10 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
11 or OS=="netbsd" or OS=="android"', { 11 or OS=="netbsd" or OS=="android"', {
12 'target_defaults': { 12 'target_defaults': {
13 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter', 13 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',
14 '-Wnon-virtual-dtor', '-pthread', '-fno-rtti', 14 '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
15 '-pedantic', '-std=gnu++0x', '-fexceptions', ], 15 '-pedantic', '-std=c++0x', '-fexceptions', ],
Wladimir Palant 2013/05/16 10:32:19 -Wno-error flags were merely left-overs from back
Felix Dahlke 2013/05/23 13:35:44 We should use -std=c++0x if possible, -std=gnu++0x
16 'ldflags': [ '-pthread', ], 16 'ldflags': [ '-pthread', ],
17 }, 17 },
18 }], 18 }],
19 ['OS=="android"', { 19 ['OS=="android"', {
20 'target_defaults': { 20 'target_defaults': {
21 'cflags!': [ 21 'cflags!': [
22 '-pthread', # Not supported by Android toolchain. 22 '-pthread', # Not supported by Android toolchain.
23 ], 23 ],
24 'ldflags!': [ 24 'ldflags!': [
25 '-pthread', # Not supported by Android toolchain. 25 '-pthread', # Not supported by Android toolchain.
26 ], 26 ],
27 }, 27 },
28 }], 28 }],
29 ], 29 ],
30 30
31 'target_defaults': { 31 'target_defaults': {
32 'msvs_cygwin_shell': 0, 32 'msvs_cygwin_shell': 0,
33 } 33 }
34 } 34 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld