Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/JsValue.h

Issue 10727002: Get rid of dependencies on v8.h in public header files (Closed)
Patch Set: Added helper class to make using v8 values via auto_ptr less awkward Created May 23, 2013, 4:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_JS_VALUE_H 18 #ifndef ADBLOCK_PLUS_JS_VALUE_H
19 #define ADBLOCK_PLUS_JS_VALUE_H 19 #define ADBLOCK_PLUS_JS_VALUE_H
20 20
21 #include <stdint.h> 21 #include <stdint.h>
22 #include <string> 22 #include <string>
23 #include <vector> 23 #include <vector>
24 #include <v8.h>
25 #include "tr1_memory.h" 24 #include "tr1_memory.h"
25 #include "V8ValueHolder.h"
26
27 namespace v8
28 {
29 class Value;
30 template <class T> class Handle;
31 template <class T> class Persistent;
Felix Dahlke 2013/05/24 15:45:41 Doesn't look like this is necessary.
32 }
26 33
27 namespace AdblockPlus 34 namespace AdblockPlus
28 { 35 {
29 class JsValue; 36 class JsValue;
30 class JsEngine; 37 class JsEngine;
31 38
32 typedef std::tr1::shared_ptr<JsValue> JsValuePtr; 39 typedef std::tr1::shared_ptr<JsValue> JsValuePtr;
33 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList; 40 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;
34 41
35 // Forward declaration to avoid including JsEngine.h 42 // Forward declaration to avoid including JsEngine.h
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 SetProperty(name, static_cast<int64_t>(val)); 76 SetProperty(name, static_cast<int64_t>(val));
70 } 77 }
71 std::string GetClass() const; 78 std::string GetClass() const;
72 JsValuePtr Call(const JsValueList& params = JsValueList(), 79 JsValuePtr Call(const JsValueList& params = JsValueList(),
73 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const; 80 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
74 protected: 81 protected:
75 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value); 82 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
76 void SetProperty(const std::string& name, v8::Handle<v8::Value> val); 83 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
77 84
78 JsEnginePtr jsEngine; 85 JsEnginePtr jsEngine;
79 v8::Persistent<v8::Value> value; 86 V8ValueHolder<v8::Value> value;
80 }; 87 };
81 } 88 }
82 89
83 #endif 90 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld