Pass browser locale to the JS code

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginDictionary.h"
 #include "PluginHttpRequest.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 #include "PluginUtil.h"
 
 #include "AdblockPlusClient.h"
 
 #include "../shared/AutoHandle.h"
 #include "../shared/Communication.h"
 
 namespace
 {
   void SpawnAdblockPlusEngine()
   {
     std::wstring engineExecutablePath = DllDir() + L"AdblockPlusEngine.exe";
+    CString browserLanguage = CPluginSystem::GetInstance()->GetBrowserLanguage();
     STARTUPINFO startupInfo = {};
     PROCESS_INFORMATION processInformation = {};
 
     HANDLE token;
     OpenProcessToken(GetCurrentProcess(), TOKEN_DUPLICATE | TOKEN_ADJUST_DEFAULT | TOKEN_QUERY | TOKEN_ASSIGN_PRIMARY, &token);
     HANDLE newToken;
     DuplicateTokenEx(token, 0, 0, SecurityImpersonation, TokenPrimary, &newToken);
 
-    if (!CreateProcessAsUser(newToken, 0, const_cast<wchar_t*>(engineExecutablePath.c_str()), 0, 0, 0, 0, 0, 0,
-                             &startupInfo, &processInformation))
+    if (!CreateProcessAsUserW(newToken, engineExecutablePath.c_str(),
+                              browserLanguage.GetBuffer(browserLanguage.GetLength() + 1),

[Felix Dahlke, 2013/06/04 09:46:09]

I'd prefer const_cast<LPWSTR>(browserLanguage.c_str()). Does the same and it's
shorter.

[Wladimir Palant, 2013/06/04 11:28:45]

No, it doesn't do the same thing (besides, browserLanguage is a CString, not
std::string). According to the docs, CreateProcessAsUserW might write to the
buffer passed in - GetBuffer() informs the CString class about that. Messing
with the internal buffer without calling GetBuffer() isn't recommended.

[Felix Dahlke, 2013/06/04 11:34:20]

Oh, tought it had c_str() or some equivalent. Well it appears it implements the
cast operator, so it can just be const_cast<LPWSTR>(browserLanguage).

According to the docs, CreateProcessAsUserW might write to the
Oh, you're right. From the docs: "The Unicode version of this function,
CreateProcessAsUserW, can modify the contents of this string."

Seems I missed that. GetBuffer is indeed better then.

+                              0, 0, 0, 0, 0, 0, &startupInfo, &processInformation))
     {
       DWORD error = GetLastError();
       throw std::runtime_error("Failed to start Adblock Plus Engine");
     }
 
     CloseHandle(processInformation.hProcess);
     CloseHandle(processInformation.hThread);
   }
 
   std::auto_ptr<Communication::Pipe> OpenAdblockPlusEnginePipe()
@@ skipping 319 matching lines @@
   try
   {
     CallAdblockPlusEngineProcedure(request);
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
   }
 }