src/plugin/PluginFilter.h - Issue 10955040: Fix domain whitelisting and remove unused code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/plugin/PluginFilter.h

Issue 10955040: Fix domain whitelisting and remove unused code (Closed)

Patch Set: Addressed all issues Created June 25, 2013, 2:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #ifndef _PLUGIN_FILTER_H_	1 #ifndef _PLUGIN_FILTER_H_

2 #define _PLUGIN_FILTER_H_	2 #define _PLUGIN_FILTER_H_

3	3

4	4

5 #include "PluginTypedef.h"	5 #include "PluginTypedef.h"

6 #include <memory>	6 #include <memory>

7 #include "..\shared\Utils.h"	7 #include "..\shared\Utils.h"

8	8

9 enum CFilterElementHideAttrPos	9 enum CFilterElementHideAttrPos

10 {	10 {

(...skipping 154 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
165	165

166 bool LoadHideFilters(std::vector<std::string> filters);	166 bool LoadHideFilters(std::vector<std::string> filters);

167	167

168 bool AddFilterElementHide(CString filter);	168 bool AddFilterElementHide(CString filter);

169	169

170	170

171 bool IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& dom ain, const CString& indent) const;	171 bool IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& dom ain, const CString& indent) const;

172	172

173	173

174 bool ShouldBlock(CString src, int contentType, const CString& domain, bool add Debug=false) const;	174 bool ShouldBlock(CString src, int contentType, const CString& domain, bool add Debug=false) const;

175 bool ShouldWhiteList(CString url) const;

176 };	175 };

177	176

178	177

179 #endif // _PLUGIN_FILTER_H_	178 #endif // _PLUGIN_FILTER_H_

OLD	NEW