Fix domain whitelisting and remove unused code

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginHttpRequest.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 
@@ skipping 183 matching lines @@
 {
   bool isHidden;
   m_criticalSectionFilter.Lock();
   {
     isHidden = filter && filter->IsElementHidden(tag, pEl, domain, indent);
   }
   m_criticalSectionFilter.Unlock();
   return isHidden;
 }
 
-bool CAdblockPlusClient::IsUrlWhiteListed(const CString& url)

[Felix Dahlke, 2013/06/25 09:46:58]

Do you think I should change this to accept an std::string? Most methods of
AdblockPlusClient want one.

[Wladimir Palant, 2013/06/25 12:00:40]

Yes, that would be nice - we should be gradually moving away from CString.

-{
-  Communication::OutputBuffer request;
-  request << Communication::PROC_IS_WHITELISTED_URL << ToUtf8String(std::wstring(url));
+bool CAdblockPlusClient::IsWhitelistedUrl(const std::string& url)

[Wladimir Palant, 2013/06/25 18:03:58]

I would actually expect to see std::wstring here - the conversion to UTF-8 is an
implementation detail of libadblockplus.

[Felix Dahlke, 2013/06/26 09:32:55]

Yes, that seems to make more sense, since the plugin works with UTF-16
internally. However, all the other methods have std::string in their signatures,
so I opted for that. I suppose it makes sense to change all of that to
std::wstring, would rather to that in a separate commit though.

[Wladimir Palant, 2013/06/27 05:55:02]

Yes, the other methods seem wrong as well. I'm fine with changing it all later
then.

+{
+  Communication::OutputBuffer request;
+  request << Communication::PROC_IS_WHITELISTED_URL << url;
 
   try
   {
     Communication::InputBuffer response = CallAdblockPlusEngineProcedure(request);
 
     bool isWhitelisted;
     response >> isWhitelisted;
     return isWhitelisted;
   }
   catch (const std::exception& e)
@@ skipping 152 matching lines @@
 
   try
   {
     CallAdblockPlusEngineProcedure(request);
   }
   catch (const std::exception& e)
   {
     DEBUG_GENERAL(e.what());
   }
 }