Switch to bwm-ng for bandwidth monitoring

modules/nagios/files/check_bandwidth

 #!/usr/bin/env python
 
 import os, re, subprocess, sys
 
 def format_bandwidth(bits):
-  if bits >= 2000000:

[Felix Dahlke, 2013/07/02 09:55:32]

Shouldn't it be 1000000 here and 1000 below?

[Wladimir Palant, 2013/07/02 10:25:16]

Not sure, I slightly remember that 1610 kbit/s is more readable than 1.61
Mbit/s. But it doesn't really matter, I can fix that.

+  if bits >= 1000000:
     return "%.2f Mbit/s" % (bits / 1000000)
-  elif bits >= 2000:
+  elif bits >= 1000:
     return "%.2f kbit/s" % (bits / 1000)
   else:
     return "%.2f bit/s" % bits
 
 if __name__ == "__main__":
   if len(sys.argv) != 3:
     script_name = os.path.basename(sys.argv[0])
     print "Usage: %s WARN CRIT" % script_name
     sys.exit(0)
 
   (warn, crit) = sys.argv[1:3]
   warn = int(sys.argv[1])
   crit = int(sys.argv[2])
 
-  vnstat_output = subprocess.check_output(["bwm-ng", "-I", "eth0", "-t", "5000", "-c", "1", "-o", "csv"])

[Wladimir Palant, 2013/06/28 10:12:22]

Oops, maybe I should have changed the name of that variable :)

[Felix Dahlke, 2013/07/02 09:55:32]

Yup, please do :P

-  data = vnstat_output.splitlines()[0].split(";")
+  process_output = subprocess.check_output(["bwm-ng", "-I", "eth0", "-t", "5000", "-c", "1", "-o", "csv"])
+  data = process_output.splitlines()[0].split(";")
   tx = float(data[2]) * 8
   rx = float(data[3]) * 8
   status = "rx %s tx %s" % (format_bandwidth(rx), format_bandwidth(tx))
 
-  perfdata = "rx=%i;%s;%s tx=%i;%s;%s" % (rx, warn, crit, tx, warn, crit)

[Wladimir Palant, 2013/06/28 10:12:22]

Might be better to use %i for the other parameters as well.

[Felix Dahlke, 2013/07/02 09:55:32]

Yes, no idea why I didn't.

+  perfdata = "rx=%i;%i;%i tx=%i;%i;%i" % (rx, warn, crit, tx, warn, crit)
 
   output = "%s|%s" % (status, perfdata)
 
   if rx >= crit or tx >= crit:
     print "CRITICAL - " + output
     sys.exit(2)
 
   if rx >= warn or tx >= warn:
     print "WARNING - " + output
     sys.exit(1)
 
   print "OK - " + output