Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: WixInstaller/Makefile

Issue 10996004: Installer: Make sure that wixobj files are rebuilt for version changes (Closed)
Patch Set: Created June 14, 2013, 2:26 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WixInstaller/Makefile
===================================================================
--- a/WixInstaller/Makefile
+++ b/WixInstaller/Makefile
@@ -58,21 +58,21 @@ setup: $(Setup)
Candle = candle -nologo -dNoDefault -dVersion=$(VERSION) "-dConfiguration=$(Configuration)" $(CANDLE_FLAGS) $(*F).wxs -out $@
.wxs{$(Build_Dir_common)}.wixobj:
$(Candle)
.wxs{$(Build_Dir_ia32)}.wixobj:
$(Candle) -arch x86
.wxs{$(Build_Dir_x64)}.wixobj:
$(Candle) -arch x64
-objects_common = $(Build_Dir_common)custom_WixUI_InstallDir.wixobj
-objects_ia32 = $(Build_Dir_ia32)adblockplusie.wixobj $(objects_common)
-objects_x64 = $(Build_Dir_x64)adblockplusie.wixobj $(objects_common)
+objects_common = $(Build_Dir_common)custom_WixUI_InstallDir-$(VERSION).wixobj
+objects_ia32 = $(Build_Dir_ia32)adblockplusie-$(VERSION).wixobj $(objects_common)
+objects_x64 = $(Build_Dir_x64)adblockplusie-$(VERSION).wixobj $(objects_common)
Eric 2013/06/14 14:39:10 I don't think $(objects_ia32) and $(objects_x64) w
-object_setup = $(Build_Dir_common)setup.wixobj
+object_setup = $(Build_Dir_common)setup-$(VERSION).wixobj
Eric 2013/06/14 14:39:10 This one will work because there's an explicit dep
$(object_setup): setup.wxs
$(Candle) -ext WixBalExtension
#---------------------
# light .wixobj --> .msi
#---------------------
Light = light -notidy -nologo -cultures:en-us -loc en-us.wxl -ext WixUIExtension -out $@
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld