Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginClientBase.cpp

Issue 11013110: Cleanup (Closed)
Left Patch Set: Created July 5, 2013, 3:28 a.m.
Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/PluginClassThread.cpp ('k') | src/plugin/PluginConfig.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #include "PluginStdAfx.h" 1 #include "PluginStdAfx.h"
2 2
3 // Internet / FTP 3 // Internet / FTP
4 #include <wininet.h> 4 #include <wininet.h>
5 5
6 // IP adapter 6 // IP adapter
7 #include <iphlpapi.h> 7 #include <iphlpapi.h>
8 8
9 #include "PluginSettings.h" 9 #include "PluginSettings.h"
10 #include "PluginSystem.h" 10 #include "PluginSystem.h"
(...skipping 24 matching lines...) Expand all
35 } 35 }
36 36
37 37
38 CPluginClientBase::~CPluginClientBase() 38 CPluginClientBase::~CPluginClientBase()
39 { 39 {
40 } 40 }
41 41
42 42
43 bool CPluginClientBase::IsValidDomain(const CString& domain) 43 bool CPluginClientBase::IsValidDomain(const CString& domain)
44 { 44 {
45 return domain != ABPDOMAIN && 45 return domain != L"about:blank" &&
46 domain != USERS_HOST &&
47 domain != L"about:blank" &&
48 domain != L"about:tabs" && 46 domain != L"about:tabs" &&
49 domain.Find(L"javascript:") != 0 && 47 domain.Find(L"javascript:") != 0 &&
50 !domain.IsEmpty(); 48 !domain.IsEmpty();
51 } 49 }
52 50
53 51
54 CString& CPluginClientBase::UnescapeUrl(CString& url) 52 CString& CPluginClientBase::UnescapeUrl(CString& url)
55 { 53 {
56 CString unescapedUrl; 54 CString unescapedUrl;
57 DWORD cb = 2048; 55 DWORD cb = 2048;
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 118
121 hasError = true; 119 hasError = true;
122 120
123 s_pluginErrors.erase(it); 121 s_pluginErrors.erase(it);
124 } 122 }
125 } 123 }
126 s_criticalSectionLocal.Unlock(); 124 s_criticalSectionLocal.Unlock();
127 125
128 return hasError; 126 return hasError;
129 } 127 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld