Cleanup

src/plugin/PluginSettings.h

 /**
 * This class contains all client functionality of the IE plugin
 *
 * Exception errors are tested by calls to ExceptionsTest from: Main ...
 */
 
 #ifndef _PLUGIN_SETTINGS_H_
 #define _PLUGIN_SETTINGS_H_
 
 
@@ skipping 40 matching lines @@
 class CPluginSettings
 {
 
 public:
 
   typedef std::map<CString, CString> TProperties;
 
 private:
 
   bool m_isFirstRun;
-  bool m_isFirstRunUpdate;

[Wladimir Palant, 2013/07/05 09:26:45]

I think that these two properties and the corresponding methods can be removed
as well.

 
-  DWORD m_dwMainProcessId;
-  DWORD m_dwMainThreadId;
-  DWORD m_dwMainUiThreadId;
   DWORD m_dwWorkingThreadId;
 
-  CString m_tabNumber;
-
-  bool m_isDirty;

[Wladimir Palant, 2013/07/05 09:26:45]

You can remove that property, all code using it has been removed.

-
-  CString m_settingsVersion;

[Wladimir Palant, 2013/07/05 09:26:45]

That property is unused.

-
   static CComAutoCriticalSection s_criticalSectionLocal;
-#ifdef SUPPORT_WHITELIST
-  static CComAutoCriticalSection s_criticalSectionDomainHistory;

[Wladimir Palant, 2013/07/05 09:26:45]

This property is unused.

-#endif
 
   void Clear();
 
   // Private constructor used by the singleton pattern
   CPluginSettings();
 public:
 
   ~CPluginSettings();
 
   static CPluginSettings* s_instance;
 
-  static bool s_isLightOnly;

[Wladimir Palant, 2013/07/05 09:26:45]

This property seems unused.

   static bool HasInstance();
   static CPluginSettings* GetInstance();
 
   static CString GetDataPath(const CString& filename=L"");
 
-  static CString GetTempPath(const CString& filename=L"");
-  static CString GetTempFile(const CString& prefix, const CString& extension=L"");

[Wladimir Palant, 2013/07/05 09:26:45]

These two methods seem unused.

-
-  CString GetPluginId();

[Wladimir Palant, 2013/07/05 09:26:45]

This method isn't even implemented.

-
   bool IsPluginEnabled() const;
 
-  bool IsPluginSelftestEnabled();

[Wladimir Palant, 2013/07/05 09:26:45]

This method isn't even implemented.

-
-  bool FilterlistExpired(CString filterlist) const;
-  bool SetFilterRefreshDate(CString filterlist, time_t refreshtime);

[Wladimir Palant, 2013/07/05 09:26:45]

These two methods aren't even implemented.

-
   std::map<CString, CString> GetFilterLanguageTitleList() const;
-
-  void SetMainProcessId();
-  void SetMainProcessId(DWORD id);
-  bool IsMainProcess(DWORD dwProcessId=0) const;
-
-  void SetMainUiThreadId();
-  void SetMainUiThreadId(DWORD id);
-  bool IsMainUiThread(DWORD dwThread=0) const;
-
-  void SetMainThreadId();
-  void SetMainThreadId(DWORD id);
-  bool IsMainThread(DWORD dwThread=0) const;
 
   void SetWorkingThreadId();
   void SetWorkingThreadId(DWORD id);
   bool IsWorkingThread(DWORD dwThread=0) const;
 
   void SetFirstRun();
   bool IsFirstRun() const;
-
-  void SetFirstRunUpdate();
-  bool IsFirstRunUpdate() const;
-
-  bool IsFirstRunAny() const;
 
   static CString GetSystemLanguage();
   DWORD m_WindowsBuildNumber;
 
 private:
 
   bool m_isPluginEnabledTab;
 
 public:
-
-  CString GetTabNumber() const;
-
-  bool IncrementTabCount();
-  bool DecrementTabCount();
 
   void TogglePluginEnabled();
   void SetPluginDisabled();
   void SetPluginEnabled();
   bool GetPluginEnabled() const;
 
   void AddError(const CString& error, const CString& errorCode);
 
   // Settings whitelist
 #ifdef SUPPORT_WHITELIST
@@ skipping 10 matching lines @@
   int GetWhiteListedDomainCount() const;
   std::vector<std::wstring> GetWhiteListedDomainList();
 #endif //SUPPORT_WHITELIST
 
   bool RefreshWhitelist();
   DWORD GetWindowsBuildNumber();
 
   void SetSubscription(const std::wstring& url);
   void SetDefaultSubscription();
   CString GetSubscription();
-  void RefreshFilterlist();
 
   bool GetStatusBarAsked();
-  void SetStatusBarAsked(bool asked);
+  void SetStatusBarAsked();
   std::vector<SubscriptionDescription> m_subscriptions;
 };
 
 
 #endif // _PLUGIN_SETTINGS_H_