Cleanup

src/plugin/PluginDebug.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginDebug.h"
 #include "PluginMutex.h"
 #include "PluginSettings.h"
 
 
 class CPluginDebugLock : public CPluginMutex
 {
 
@@ skipping 26 matching lines @@
 #endif
 
   if (CPluginSettings::HasInstance())
   {
 #ifdef ENABLE_DEBUG_SPLIT_FILE
     CPluginSettings* settings = CPluginSettings::GetInstance();
 
     bool isWorkingThread = settings->IsWorkingThread(dwThreadId);
 
     CString processor;
-    WCHAR tmp[10];

[Wladimir Palant, 2013/07/22 06:43:11]

I would rather use wchar_t rather than WCHAR - that's the type that _itow_s
takes according to documentation.

-    _itow_s<10>(::GetCurrentProcessId(), tmp, 10);

[Wladimir Palant, 2013/07/22 06:43:11]

I think you can leave out the template parameter here, that's the whole point of
the templated variant:

  _itow_s(::GetCurrentProcessId(), tmp, 10);

+    wchar_t tmp[10];
+    _itow_s(::GetCurrentProcessId(), tmp, 10);
     if (isWorkingThread)
       processor = L"tab" + CString(tmp) + L"_thread";
     else
-      processor = L"tab" + ::CString(tmp) + L"_ui";

[Wladimir Palant, 2013/07/22 06:43:11]

CString() or ::CString()? Please choose one ;)

+      processor = L"tab" + CString(tmp) + L"_ui";
 #else
     if (dwProcessId == 0)
     {
       dwProcessId = ::GetCurrentProcessId();
     }
     if (dwThreadId == 0)
     {
       dwThreadId = ::GetCurrentThreadId();
     }
 
@@ skipping 174 matching lines @@
     srcTrunc = src.Left(67) + L"..." + src.Right(30);
   }
 
   CString blocking;
   blocking.Format(L"Ignored  %-12s  %s  %s", type, domain.IsEmpty()? L"-" : domain, srcTrunc);
 
   DebugResult(blocking);
 }
 
 #endif // ENABLE_DEBUG_RESULT_IGNORED