Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/AdblockPlusClient.h

Issue 11013110: Cleanup (Closed)
Left Patch Set: Minor CallEngine refactoring Created July 26, 2013, 2:12 p.m.
Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/AdblockPlus.rc ('k') | src/plugin/AdblockPlusClient.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #ifndef _ADBLOCK_PLUS_CLIENT_H_ 1 #ifndef _ADBLOCK_PLUS_CLIENT_H_
2 #define _ADBLOCK_PLUS_CLIENT_H_ 2 #define _ADBLOCK_PLUS_CLIENT_H_
3 3
4 4
5 #include "PluginTypedef.h" 5 #include "PluginTypedef.h"
6 #include "PluginClientBase.h" 6 #include "PluginClientBase.h"
7 #include "../shared/Communication.h" 7 #include "../shared/Communication.h"
8 8
9 9
10 class CPluginFilter; 10 class CPluginFilter;
(...skipping 14 matching lines...) Expand all
25 std::auto_ptr<CPluginFilter> m_filter; 25 std::auto_ptr<CPluginFilter> m_filter;
26 26
27 CComAutoCriticalSection m_criticalSectionFilter; 27 CComAutoCriticalSection m_criticalSectionFilter;
28 CComAutoCriticalSection m_criticalSectionCache; 28 CComAutoCriticalSection m_criticalSectionCache;
29 29
30 std::map<CString,bool> m_cacheBlockedSources; 30 std::map<CString,bool> m_cacheBlockedSources;
31 31
32 32
33 // Private constructor used by the singleton pattern 33 // Private constructor used by the singleton pattern
34 CAdblockPlusClient(); 34 CAdblockPlusClient();
35
36 void PostRequest(Communication::OutputBuffer request);
Wladimir Palant 2013/07/26 16:45:37 I don't think you are still implementing this meth
37 public: 35 public:
38 36
39 static CAdblockPlusClient* s_instance; 37 static CAdblockPlusClient* s_instance;
40 38
41 ~CAdblockPlusClient(); 39 ~CAdblockPlusClient();
42 40
43 static CAdblockPlusClient* GetInstance(); 41 static CAdblockPlusClient* GetInstance();
44 42
45 // Removes the url from the list of whitelisted urls if present 43 // Removes the url from the list of whitelisted urls if present
46 // Only called from ui thread 44 // Only called from ui thread
(...skipping 16 matching lines...) Expand all
63 void SetPref(const std::wstring& name, const std::wstring& value); 61 void SetPref(const std::wstring& name, const std::wstring& value);
64 void SetPref(const std::wstring& name, const int64_t& value); 62 void SetPref(const std::wstring& name, const int64_t& value);
65 void SetPref(const std::wstring& name, bool value); 63 void SetPref(const std::wstring& name, bool value);
66 std::wstring GetPref(const std::wstring& name, const std::wstring& defaultValu e = L""); 64 std::wstring GetPref(const std::wstring& name, const std::wstring& defaultValu e = L"");
67 std::wstring GetPref(const std::wstring& name, const wchar_t* defaultValue); 65 std::wstring GetPref(const std::wstring& name, const wchar_t* defaultValue);
68 bool GetPref(const std::wstring& name, bool defaultValue = false); 66 bool GetPref(const std::wstring& name, bool defaultValue = false);
69 int64_t GetPref(const std::wstring& name, int64_t defaultValue = 0); 67 int64_t GetPref(const std::wstring& name, int64_t defaultValue = 0);
70 }; 68 };
71 69
72 #endif // _ADBLOCK_PLUS_CLIENT_H_ 70 #endif // _ADBLOCK_PLUS_CLIENT_H_
LEFTRIGHT

Powered by Google App Engine
This is Rietveld