Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginClass.cpp

Issue 11013110: Cleanup (Closed)
Left Patch Set: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing … Created July 9, 2013, 12:59 p.m.
Right Patch Set: More beautification and addressing comments Created July 29, 2013, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/PluginClass.h ('k') | src/plugin/PluginClassThread.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #include "PluginStdAfx.h" 1 #include "PluginStdAfx.h"
2 2
3 #include "PluginClass.h" 3 #include "PluginClass.h"
4 #include "PluginSettings.h" 4 #include "PluginSettings.h"
5 #include "PluginSystem.h" 5 #include "PluginSystem.h"
6 #ifdef SUPPORT_FILTER 6 #ifdef SUPPORT_FILTER
7 #include "PluginFilter.h" 7 #include "PluginFilter.h"
8 #endif 8 #endif
9 #include "PluginMimeFilterClient.h" 9 #include "PluginMimeFilterClient.h"
10 #include "PluginClient.h" 10 #include "PluginClient.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 m_hTabWnd = NULL; 62 m_hTabWnd = NULL;
63 m_hStatusBarWnd = NULL; 63 m_hStatusBarWnd = NULL;
64 m_hPaneWnd = NULL; 64 m_hPaneWnd = NULL;
65 m_nPaneWidth = 0; 65 m_nPaneWidth = 0;
66 m_pWndProcStatus = NULL; 66 m_pWndProcStatus = NULL;
67 m_hTheme = NULL; 67 m_hTheme = NULL;
68 m_isInitializedOk = false; 68 m_isInitializedOk = false;
69 69
70 70
71 m_tab = new CPluginTab(this); 71 m_tab = new CPluginTab(this);
72
73 // Load settings (fetch the available subscriptions, if still not fetched)
74 CPluginSettings* settings = CPluginSettings::GetInstance();
75 72
76 CPluginSystem* system = CPluginSystem::GetInstance(); 73 CPluginSystem* system = CPluginSystem::GetInstance();
77 74
78 std::wstring locale((LPCWSTR)system->GetBrowserLanguage()); 75 std::wstring locale((LPCWSTR)system->GetBrowserLanguage());
79 Dictionary::Create(locale); 76 Dictionary::Create(locale);
80 } 77 }
81 78
82 CPluginClass::~CPluginClass() 79 CPluginClass::~CPluginClass()
83 { 80 {
84 delete m_tab; 81 delete m_tab;
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 } 418 }
422 } 419 }
423 return trueth == 1; 420 return trueth == 1;
424 } 421 }
425 422
426 void CPluginClass::ShowStatusBar() 423 void CPluginClass::ShowStatusBar()
427 { 424 {
428 VARIANT_BOOL isVisible; 425 VARIANT_BOOL isVisible;
429 426
430 CPluginSettings* settings = CPluginSettings::GetInstance(); 427 CPluginSettings* settings = CPluginSettings::GetInstance();
431
432 //TODO: Remove the message box
433 MessageBox(NULL, L"", L"", MB_OK);
Wladimir Palant 2013/07/11 12:53:10 Please address that TODO comment ;)
434 428
435 CComQIPtr<IWebBrowser2> browser = GetAsyncBrowser(); 429 CComQIPtr<IWebBrowser2> browser = GetAsyncBrowser();
436 if (browser) 430 if (browser)
437 { 431 {
438 HRESULT hr = S_OK; 432 HRESULT hr = S_OK;
439 hr = browser->get_StatusBar(&isVisible); 433 hr = browser->get_StatusBar(&isVisible);
440 if (SUCCEEDED(hr)) 434 if (SUCCEEDED(hr))
441 { 435 {
442 if (!isVisible) 436 if (!isVisible)
443 { 437 {
(...skipping 1522 matching lines...) Expand 10 before | Expand all | Expand 10 after
1966 } 1960 }
1967 } 1961 }
1968 } 1962 }
1969 1963
1970 hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT); 1964 hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
1971 } 1965 }
1972 1966
1973 return hTabWnd; 1967 return hTabWnd;
1974 1968
1975 } 1969 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld