Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/AdblockPlusTab.cpp

Issue 11013110: Cleanup (Closed)
Patch Set: Whole cleanup + comments addressed Created July 23, 2013, 11:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/AdblockPlusTab.cpp
===================================================================
--- a/src/plugin/AdblockPlusTab.cpp
+++ b/src/plugin/AdblockPlusTab.cpp
@@ -3,7 +3,6 @@
#include "PluginSettings.h"
#include "PluginSystem.h"
#include "PluginClass.h"
-#include "PluginConfiguration.h"
#include "PluginClientFactory.h"
#include "AdblockPlusTab.h"
@@ -21,27 +20,4 @@
void CPluginTab::OnNavigate(const CString& url)
Felix Dahlke 2013/07/25 13:52:33 I don't think there's any point in overwriting thi
Oleksandr 2013/07/26 14:20:04 You're right. I'd still leave the CPuginTab class
{
CPluginTabBase::OnNavigate(url);
-
- int r = url.Find(L".simple-adblock.com");
- if ((r > 0) && (r < 15))
- {
- if (url.Find(L"?update") > 0)
- {
- CPluginConfiguration pluginConfig;
- pluginConfig.Download();
- DWORD id;
- HANDLE handle = ::CreateThread(NULL, 0, CPluginClass::MainThreadProc, (LPVOID)this, NULL, &id);
- CPluginSettings* settings = CPluginSettings::GetInstance();
-
- //Also register a mime filter if it's not registered yet
- if (CPluginClass::s_mimeFilter == NULL)
- {
- CPluginClass::s_mimeFilter = CPluginClientFactory::GetMimeFilterClientInstance();
- }
-
- settings->Write();
- this->OnUpdateConfig();
- this->OnUpdateSettings(true);
- }
- }
}

Powered by Google App Engine
This is Rietveld