Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginSettings.h

Issue 11013110: Cleanup (Closed)
Patch Set: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing … Created July 9, 2013, 12:59 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginSettings.h
===================================================================
--- a/src/plugin/PluginSettings.h
+++ b/src/plugin/PluginSettings.h
@@ -58,23 +58,12 @@
private:
bool m_isFirstRun;
- bool m_isFirstRunUpdate;
- DWORD m_dwMainProcessId;
- DWORD m_dwMainThreadId;
- DWORD m_dwMainUiThreadId;
DWORD m_dwWorkingThreadId;
- CString m_tabNumber;
-
- bool m_isDirty;
-
CString m_settingsVersion;
Wladimir Palant 2013/07/11 12:53:10 Still unused.
static CComAutoCriticalSection s_criticalSectionLocal;
-#ifdef SUPPORT_WHITELIST
- static CComAutoCriticalSection s_criticalSectionDomainHistory;
-#endif
void Clear();
@@ -92,32 +81,10 @@
static CString GetDataPath(const CString& filename=L"");
- static CString GetTempPath(const CString& filename=L"");
- static CString GetTempFile(const CString& prefix, const CString& extension=L"");
-
- CString GetPluginId();
-
bool IsPluginEnabled() const;
- bool IsPluginSelftestEnabled();
-
- bool FilterlistExpired(CString filterlist) const;
- bool SetFilterRefreshDate(CString filterlist, time_t refreshtime);
-
std::map<CString, CString> GetFilterLanguageTitleList() const;
- void SetMainProcessId();
- void SetMainProcessId(DWORD id);
- bool IsMainProcess(DWORD dwProcessId=0) const;
-
- void SetMainUiThreadId();
- void SetMainUiThreadId(DWORD id);
- bool IsMainUiThread(DWORD dwThread=0) const;
-
- void SetMainThreadId();
- void SetMainThreadId(DWORD id);
- bool IsMainThread(DWORD dwThread=0) const;
-
void SetWorkingThreadId();
void SetWorkingThreadId(DWORD id);
bool IsWorkingThread(DWORD dwThread=0) const;
@@ -125,11 +92,6 @@
void SetFirstRun();
bool IsFirstRun() const;
- void SetFirstRunUpdate();
- bool IsFirstRunUpdate() const;
-
- bool IsFirstRunAny() const;
-
static CString GetSystemLanguage();
DWORD m_WindowsBuildNumber;
@@ -139,11 +101,6 @@
public:
- CString GetTabNumber() const;
-
- bool IncrementTabCount();
- bool DecrementTabCount();
-
void TogglePluginEnabled();
void SetPluginDisabled();
void SetPluginEnabled();
@@ -173,10 +130,9 @@
void SetSubscription(const std::wstring& url);
void SetDefaultSubscription();
CString GetSubscription();
- void RefreshFilterlist();
bool GetStatusBarAsked();
- void SetStatusBarAsked(bool asked);
+ void SetStatusBarAsked();
std::vector<SubscriptionDescription> m_subscriptions;
};

Powered by Google App Engine
This is Rietveld