First run detection fix

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 142 matching lines @@
     ::Sleep(10);
 }
 
 void FilterEngine::InitDone(JsValueList& params)
 {
   jsEngine->RemoveEventCallback("init");
   initialized = true;
   firstRun = params.size() && params[0]->AsBool();
 }
 
-bool FilterEngine::IsFirstRun() const
+bool FilterEngine::IsFirstRun()
 {
-  return firstRun;
+  bool temp = firstRun;
+  firstRun = false;
+  return temp;

[Wladimir Palant, 2013/07/11 11:36:21]

Debug code?

[Oleksandr, 2013/07/11 12:18:45]

Not actually. My thinking was that the first run automatically becomes a second
run if IsFirstRun is called. Otherwise we can have an engine instance hanging,
stating that it's a first run, when in fact it's not.

[Wladimir Palant, 2013/07/11 12:56:20]

I see. I actually suggested in the other review that this logic should be
implemented in the adblockplusie engine - calling IsFirstRun() in the engine
shouldn't cause unexpected side-effects. And it isn't given that all
applications only want to query IsFirstRun() once.

 }
 
 FilterPtr FilterEngine::GetFilter(const std::string& text)
 {
   JsValuePtr func = jsEngine->Evaluate("API.getFilterFromText");
   JsValueList params;
   params.push_back(jsEngine->NewValue(text));
   return FilterPtr(new Filter(func->Call(params)));
 }
 
@@ skipping 94 matching lines @@
   func->Call(params);
 }
 
 void FilterEngine::UpdateCheckDone(const std::string& eventName, FilterEngine::UpdaterCallback callback, JsValueList& params)
 {
   jsEngine->RemoveEventCallback(eventName);
 
   std::string error(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsString() : "");
   callback(error);
 }