first run page redesign

chrome/content/ui/firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+

[Thomas Greiner, 2013/07/26 14:22:55]

:)

 (function()
 {
-  var shade;
-  var scrollTimer;
-
   // Load subscriptions for features
   var featureSubscriptions = [
     {
       feature: "malware",
       homepage: "http://malwaredomains.com/",
       title: "Malware Domains",
       url: "https://easylist-downloads.adblockplus.org/malwaredomains_full.txt"
     },
     {
       feature: "social",
       homepage: "https://www.fanboy.co.nz/",
       title: "Fanboy's Social Blocking List",
       url: "https://easylist-downloads.adblockplus.org/fanboy-social.txt"
     },
     {
       feature: "tracking",
       homepage: "https://easylist.adblockplus.org/",
       title: "EasyPrivacy",
       url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
     }
   ];
 
+
+  function showFeature()
+  {
+    var toggleButton = E("activate-features");
+    var overView = E("can-do-more-overview");
+    var expandedView = E("can-do-more-expanded");
+
+    if(toggleButton.getAttribute("data-status") == "overview")

[Thomas Greiner, 2013/07/26 14:22:55]

Code Style:
if (...)

+    {
+      fade("out", overView, 750, true);

[Thomas Greiner, 2013/07/26 14:22:55]

750ms is a bit long. I'd prefer max 500ms.

+      setTimeout(function()
+      {
+        fade("in", expandedView, 750, true)
+      },750);
+
+      toggleButton.innerHTML = "show overview again";
+      toggleButton.setAttribute("data-status","expanded");
+
+    } 
+    else if (toggleButton.getAttribute("data-status") == "expanded")
+    {
+      fade("out", expandedView, 750, true);
+      setTimeout(function()
+      {
+          fade("in", overView, 750, true)
+      },750);
+
+      toggleButton.innerHTML = "activate features";
+      toggleButton.setAttribute("data-status", "overview");
+    }
+
+    // jQuery-style fading

[Thomas Greiner, 2013/07/26 14:22:55]

As discussed, CSS transitions should be used whenever possible.

+    function fade(type, el, duration, IEsupport) 
+    {
+      var isIn   = (type == "in"),
+        IE       = (IEsupport) ? IEsupport : false,
+        opacity  = isIn ? 0 : 1,
+        interval = 50,
+        gap      = interval / duration;
+        
+      if(isIn) 
+      {
+        el.style.display = "block";
+        el.style.opacity = opacity;
+        if(IE) 
+        {
+          el.style.filter = "alpha(opacity=" + opacity + ")";
+          el.style.filter = "progid:DXImageTransform.Microsoft.Alpha(Opacity=" + opacity + ")";
+        }
+      }
+      
+      function func() 
+      {
+        opacity = isIn ? opacity + gap : opacity - gap; 
+        el.style.opacity = opacity;
+        if(IE) 
+        {
+          el.style.filter = "alpha(opacity=" + opacity * 100 + ")";
+          el.style.filter = "progid:DXImageTransform.Microsoft.Alpha(Opacity=" + opacity * 100 + ")";
+        }
+        if(opacity <= 0 || opacity >= 1) 
+        {
+          window.clearInterval(fading); 
+        }
+        if(opacity <= 0)
+        {
+          el.style.display = "none"; 
+        }
+      }
+      var fading = window.setInterval(func, interval);
+    }
+  }
+
   function onDOMLoaded()
   {
+    var donateLink = E("donate");
+    donateLink.href = Utils.getDocLink("donate");
+    
     // Show warning if data corruption was detected
     if (typeof backgroundPage != "undefined" && backgroundPage.seenDataCorruption)
     {
       E("dataCorruptionWarning").removeAttribute("hidden");
       setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filterstorage"));
     }
 
     // Set up URL
     setLinks("acceptableAdsExplanation", Utils.getDocLink("acceptable_ads_criteria"), openFilters);
 
-    shade = E("shade");
-    shade.addEventListener("mouseover", scrollPage, false);
-    shade.addEventListener("mouseout", stopScroll, false);
-
     // Set up feature buttons linked to subscriptions
     featureSubscriptions.forEach(setToggleSubscriptionButton);
     var filterListener = function(action)
     {
       if (/^subscription\.(added|removed|disabled)$/.test(action))
       {
         for (var i = 0; i < featureSubscriptions.length; i++)
         {
           var featureSubscription = featureSubscriptions[i];
           updateToggleButton(featureSubscription.feature, isSubscriptionEnabled(featureSubscription));
         }
       }
     }
     FilterNotifier.addListener(filterListener);
     window.addEventListener("unload", function(event)
     {
       FilterNotifier.removeListener(filterListener);
     }, false);
 
-    window.addEventListener("resize", onWindowResize, false);
-    document.addEventListener("scroll", onScroll, false);
-
-    onWindowResize();
+    // you can click activate-feature or one of the icons to toggle the features area
+    E("activate-features").addEventListener("click", showFeature, false);
+    E("can-do-more-overview").addEventListener("click", showFeature, false);
 
     initSocialLinks();
   }
 
-  function onScroll()
-  {
-    var currentHeight = document.documentElement.scrollTop + document.body.scrollTop + document.documentElement.clientHeight;
-    shade.style.opacity = (document.documentElement.scrollHeight == currentHeight) ? "0.0" : "0.5";
-  }
-
-  function onWindowResize()
-  {
-    onScroll();
-  }
-
-  function toggleTypoCorrectionEnabled()
-  {
-    Prefs.correctTypos = !Prefs.correctTypos;
-  }
-
   function isSubscriptionEnabled(featureSubscription)
   {
     return featureSubscription.url in FilterStorage.knownSubscriptions
       && !Subscription.fromURL(featureSubscription.url).disabled;
   }
 
   function setToggleSubscriptionButton(featureSubscription)
   {
     var feature = featureSubscription.feature;
 
@@ skipping 141 matching lines @@
   {
     var button = E("toggle-" + feature);
     if (isEnabled)
       button.classList.remove("off");
     else
       button.classList.add("off");
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();