Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/skin/firstRun.css

Issue 11039060: first run page redesign (Closed)
Left Patch Set: codereview updates Created Aug. 26, 2013, 3:44 p.m.
Right Patch Set: improve after wladimirs code review Created Oct. 4, 2013, 4:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 15 matching lines...) Expand all
26 26
27 @font-face { 27 @font-face {
28 font-family: 'CreteRound'; 28 font-family: 'CreteRound';
29 font-style: italic; 29 font-style: italic;
30 src: url(fonts/CreteRound-Italic.otf); 30 src: url(fonts/CreteRound-Italic.otf);
31 src: local ('Ø'), 31 src: local ('Ø'),
32 /*local ('Ø') forces using no local font called CreteRound*/ 32 /*local ('Ø') forces using no local font called CreteRound*/
33 url(fonts/CreteRound-Italic.otf) format('otf'); 33 url(fonts/CreteRound-Italic.otf) format('otf');
34 } 34 }
35 35
36 *
37 {
38 margin: 0;
39 padding: 0;
40 }
41
42 body 36 body
43 { 37 {
44 font-family: Helvetica, Arial, sans-serif; 38 font-family: Helvetica, Arial, sans-serif;
45 font-size: 15px; 39 font-size: 15px;
46 line-height: 140%; 40 line-height: 140%;
47 color: #7f776b; 41 color: #7f776b;
48 background-color: #f8f6f2; 42 background-color: #f8f6f2;
49 background-image: url(background-main.png); 43 background-image: url(background-main.png);
44 margin: 0;
45 padding: 0;
50 } 46 }
51 47
52 a, a:link, a:visited 48 a, a:link, a:visited
53 { 49 {
54 color: #5a84b3; 50 color: #5a84b3;
55 text-decoration: underline; 51 text-decoration: underline;
56 } 52 }
57 53
58 a:hover 54 a:hover
59 { 55 {
60 text-decoration: none; 56 text-decoration: none;
61 } 57 }
62 58
63 button 59 button
64 { 60 {
65 cursor: pointer; 61 cursor: pointer;
66 } 62 }
67 63
64 ul
65 {
66 margin: 0;
67 padding: 0;
68 }
69
68 li 70 li
69 { 71 {
72 margin: 0;
73 padding: 0;
70 list-style-type: none; 74 list-style-type: none;
71 } 75 }
72 76
73 header 77 header
74 { 78 {
75 height: 200px;
76 background-image: url(background.png); 79 background-image: url(background.png);
77 background-repeat: repeat-x; 80 background-repeat: repeat-x;
78 width: 100%; 81 width: 100%;
79 padding: 40px 0 0 0; 82 padding: 40px 0 0 0;
80 } 83 }
81 84
82 header h1 85 header h1
83 { 86 {
84 font-size: 24px; 87 font-size: 24px;
85 font-weight: normal; 88 font-weight: normal;
86 margin: 0 auto;
87 color: #57ab5b; 89 color: #57ab5b;
88 text-align: center; 90 text-align: center;
89 margin: 21px auto; 91 margin: 21px auto;
90 padding: 16px 0 14px 0; 92 padding: 16px 0 14px 0;
91 border: 1px #57ab5b; 93 border: 1px #57ab5b;
92 border-style: dashed none; 94 border-style: dashed none;
93 /* border parallel fix - 957px is the value 95 /* border parallel fix - 957px is the value
94 * closest to 960px(page width) which makes 96 * closest to 960px(page width) which makes
95 * the dashed border parallel 97 * the dashed border parallel
96 */ 98 */
97 max-width: 957px; 99 max-width: 957px;
98 } 100 }
99 101
100 strong
101 {
102 font-weight: 600;
103 }
104
105 h1,h2,h3 102 h1,h2,h3
106 { 103 {
107 font-family: CreteRound, Helvetica, Arial, sans-serif; 104 font-family: CreteRound, Helvetica, Arial, sans-serif;
108 } 105 }
109 106
110 h2 107 h2
111 { 108 {
112 font-size: 26px; 109 font-size: 26px;
113 font-weight: lighter; 110 font-weight: lighter;
114 color: #968d81; 111 color: #968d81;
115 line-height: 28px; 112 line-height: 28px;
116 text-align: center; 113 text-align: center;
117 114 margin: 0;
115 padding: 0;
118 } 116 }
119 117
120 h3 118 h3
121 { 119 {
122 font-size: 22px; 120 font-size: 22px;
123 color: #7F776B; 121 color: #7F776B;
124 font-weight: normal; 122 font-weight: normal;
125 margin: 0 0 10px 0; 123 margin: 0 0 10px 0;
124 padding: 0;
126 line-height: 24px; 125 line-height: 24px;
127 } 126 }
128 127
129 h4 128 h4
130 { 129 {
131 font-size: 15px; 130 font-size: 15px;
132 color: #7f776b; 131 color: #7f776b;
133 font-weight: normal; 132 font-weight: normal;
134 text-align: center; 133 text-align: center;
134 margin: 0;
135 padding: 0;
135 } 136 }
136 137
137 section 138 section
138 { 139 {
139 margin: 0 auto; 140 margin: 0 auto;
140 margin-bottom: 30px; 141 margin-bottom: 30px;
141 max-width: 760px; 142 max-width: 760px;
142 background-image: url(background.png); 143 background-image: url(background.png);
143 padding: 40px 100px; 144 padding: 40px 100px;
144 } 145 }
(...skipping 18 matching lines...) Expand all
163 { 164 {
164 max-width: 960px; 165 max-width: 960px;
165 padding: 40px 0px 0px 0px; 166 padding: 40px 0px 0px 0px;
166 } 167 }
167 168
168 #can-do-more > h2 169 #can-do-more > h2
169 { 170 {
170 margin: 0 100px; 171 margin: 0 100px;
171 } 172 }
172 173
173 .fade-out 174 .fade
174 { 175 {
175 opacity: 0; 176 opacity: 0;
176 } 177 }
177 178
178 .fade-in 179 .hide
180 {
181 display: none;
182 }
183
184 #can-do-more-overview
179 { 185 {
180 opacity: 1; 186 opacity: 1;
181 } 187 max-height: 10000px;
182
183 .hide
184 {
185 display: none;
186 }
187
188 .show
Thomas Greiner 2013/08/26 16:25:04 Doesn't seem to be used anywhere.
189 {
190 display: block;
191 }
192
193 #can-do-more-overview
194 {
195 max-width: 760px; 188 max-width: 760px;
196 min-height: 140px;
197 margin: 30px 100px 0 100px; 189 margin: 30px 100px 0 100px;
198 font-size: 0px; 190 font-size: 0px;
199 /* hides appearing spacings because of 191 /* hides appearing spacings because of
200 * using display: inline-block*/ 192 * using display: inline-block*/
201 cursor: pointer; 193 cursor: pointer;
202 -moz-transition: opacity 0.5s ease-in-out; 194 transition: opacity 0.3s step-end;
Wladimir Palant 2013/10/05 09:15:59 Shouldn't it be ease-in-out rather than step-end h
203 transition: opacity 0.5s ease-in-out; 195 -moz-transition: opacity 0.3s ease-in-out;
196 -webkit-transition: opacity 0.3s ease-in-out;
197 }
198
199 #can-do-more.expanded > #can-do-more-overview, #can-do-more.expanded > #can-do-m ore-overview li, #can-do-more.expanded > #can-do-more-overview div, #can-do-more .expanded > #can-do-more-overview h4
200 {
201 opacity: 0;
202 max-height: 0px;
203 width: 0;
204 margin: 0;
205 padding: 0;
206 transition: none;
207 -moz-transition: none;
208 -webkit-transition: none;
209 -o-transition: none;
Wladimir Palant 2013/10/05 09:15:59 We don't set -o-transition above, we shouldn't nee
204 } 210 }
205 211
206 #can-do-more-overview > li:hover 212 #can-do-more-overview > li:hover
207 { 213 {
208 background-image: url("background-main.png"); 214 background-image: url("background-main.png");
209 text-decoration: none; 215 text-decoration: none;
210 } 216 }
211 217
212 #can-do-more-overview > li 218 #can-do-more-overview > li
213 { 219 {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 } 261 }
256 262
257 .feature-tracking-image 263 .feature-tracking-image
258 { 264 {
259 background-image: url(features/tracking.png); 265 background-image: url(features/tracking.png);
260 background-repeat: no-repeat; 266 background-repeat: no-repeat;
261 } 267 }
262 268
263 #can-do-more-expanded 269 #can-do-more-expanded
264 { 270 {
271 opacity: 0;
272 max-height: 0;
273 }
274
275 #can-do-more.expanded > #can-do-more-expanded
276 {
277 opacity: 1;
278 max-height: 10000px;
265 margin: 30px 100px 0 100px; 279 margin: 30px 100px 0 100px;
280 transition: opacity 0.5s ease-in-out;
266 -moz-transition: opacity 0.5s ease-in-out; 281 -moz-transition: opacity 0.5s ease-in-out;
267 transition: opacity 0.5s ease-in-out; 282 -webkit-transition: opacity 0.5s ease-in-out;
268 } 283 transition-delay: 0.2s;
269 284 -webkit-transition-delay: 0.2s;
Wladimir Palant 2013/10/05 09:15:59 -moz-transition-delay seems to be missing here. Th
270 #features 285 }
271 { 286
272 display: block; 287 #features, .feature:not([hidden]), .feature-image, .feature-description, .featur e-description, .feature-description-textblock, .feature-description-textblock > span, .feature-image
288 {
289 width: 0;
290 height: 0;
291 margin: 0;
292 padding: 0;
293 transition: none;
294 -moz-transition: none;
295 -webkit-transition: none;
296 -o-transition: none;
297 }
298
299
300 #can-do-more.expanded #features,#can-do-more.expanded .feature:not([hidden]),#ca n-do-more.expanded .feature-image,#can-do-more.expanded .feature-description,#ca n-do-more.expanded .feature-description,#can-do-more.expanded .feature-descripti on-textblock,#can-do-more.expanded .feature-description-textblock > span,#can-do -more.expanded .feature-image
301 {
302 width: auto;
303 height: auto;
304 margin: auto;
305 padding: auto;
306 transition-property: all;
307 -moz-transition-property: all;
308 -webkit-transition-property: all;
309 -o-transition-property: all;
Wladimir Palant 2013/10/05 09:15:59 As above, -o-transition-property and -moz-transiti
310 transition-duration: 0.5s;
311 -webkit-transition-duration: 0.5s;
312 transition-timing-function: ease-in-out;
313 -webkit-transition-timing-function: ease-in-out;
314 }
315
316 #can-do-more.expanded #features
317 {
273 border-spacing: 10px; 318 border-spacing: 10px;
274 margin: 0px; 319 margin: 0px;
275 padding: 0px; 320 padding: 0px;
276 } 321 }
277 322
278 .feature:not([hidden]) 323 #can-do-more.expanded .feature:not([hidden])
279 { 324 {
280 display: block; 325 display: block;
281 list-style-type: none; 326 list-style-type: none;
282 padding: 30px 0; 327 padding: 30px 0;
283 padding-bottom: 20px; 328 padding-bottom: 20px;
284 border-top: 1px dashed #c0bebb; 329 border-top: 1px dashed #c0bebb;
285 } 330 }
286 331
287 .feature-image, .feature-description 332 #can-do-more.expanded .feature-image, #can-do-more.expanded .feature-description
288 { 333 {
289 display: inline-block; 334 display: inline-block;
290 *display: inline; /* IE6 inline-block fix */ 335 *display: inline; /* IE6 inline-block fix */
291 *zoom: 1; 336 *zoom: 1;
292 vertical-align: top; 337 vertical-align: top;
293 } 338 }
294 339
295 .feature-description 340 #can-do-more.expanded .feature-description
296 { 341 {
297 margin: 0px 0px 0 20px; 342 margin: 0px 0px 0 20px;
298 width: 625px; 343 width: 625px;
299 max-width: 85%; 344 max-width: 85%;
300 } 345 }
301 346
302 .feature-description-textblock 347 #can-do-more.expanded .feature-description-textblock
303 { 348 {
304 width: 480px; 349 width: 480px;
305 max-width: 100%; 350 max-width: 100%;
306 margin: 0 40px 0 0; 351 margin: 0 40px 0 0;
307 display: inline-block; 352 display: inline-block;
308 } 353 }
309 354
310 .feature-description-textblock > span 355 #can-do-more.expanded .feature-description-textblock > span
311 { 356 {
312 margin: 15px 0 0 0; 357 margin: 15px 0 0 0;
313 } 358 }
314 359
315 .feature-image 360 #can-do-more.expanded .feature-image
316 { 361 {
317 width: 59px; 362 width: 59px;
318 height: 59px; 363 height: 59px;
319 margin: 8px 0 10px 20px; 364 margin: 8px 0 10px 20px;
320 } 365 }
321 366
322 #activate-features 367 #activate-features
323 { 368 {
324 width: 100%; 369 width: 100%;
325 background-image: url("background-candomore.png"); 370 background-image: url("background-candomore.png");
(...skipping 30 matching lines...) Expand all
356 #label-show-expanded 401 #label-show-expanded
357 { 402 {
358 display: none; 403 display: none;
359 } 404 }
360 405
361 #label-show-overview 406 #label-show-overview
362 { 407 {
363 display: block; 408 display: block;
364 } 409 }
365 410
366 #activate-features-label:hover 411 #activate-features-label:hover
Thomas Greiner 2013/10/05 15:51:19 This is a weird behavior. It's neither restricted
367 { 412 {
368 color: #1f6822; 413 color: #1f6822;
369 } 414 }
370 415
371 .arrow
Thomas Greiner 2013/08/26 16:25:04 Merge this one with the existing .arrow rule below
372 {
373 background-image: url("arrow-down.png");
374 }
375
376 #can-do-more.expanded .arrow 416 #can-do-more.expanded .arrow
377 { 417 {
378 background-image: url("arrow-up.png"); 418 background-image: url("arrow-up.png");
379 } 419 }
380 420
381 .arrow 421 .arrow
382 { 422 {
383 width: 29px; 423 width: 29px;
384 height: 22px; 424 height: 22px;
385 vertical-align: bottom; 425 vertical-align: bottom;
386 display: inline-block; 426 display: inline-block;
427 background-image: url("arrow-down.png");
387 } 428 }
388 429
389 #share 430 #share
390 { 431 {
391 background-image: url(background-share.png); 432 background-image: url(background-share.png);
392 padding: 50px 100px 40px 100px; 433 padding: 50px 100px 40px 100px;
393 max-width: 760px; 434 max-width: 760px;
394 text-align: center; 435 text-align: center;
395 font-family: CreteRound, Helvetica, Arial, sans-serif; 436 font-family: CreteRound, Helvetica, Arial, sans-serif;
396 } 437 }
(...skipping 16 matching lines...) Expand all
413 454
414 #share span 455 #share span
415 { 456 {
416 color: #bed1e6; 457 color: #bed1e6;
417 text-align: center; 458 text-align: center;
418 line-height: 34px; 459 line-height: 34px;
419 font-size: 22px; 460 font-size: 22px;
420 display: block; 461 display: block;
421 } 462 }
422 463
423 #donate:hover, #share-buttons a:hover 464 #donate:hover, .share-buttons a:hover
424 { 465 {
425 -moz-box-shadow: 0px 0px 0px 2px #8ca7c4; 466 -moz-box-shadow: 0px 0px 0px 2px #8ca7c4;
426 -webkit-box-shadow: 0px 0px 0px 2px #8ca7c4; 467 -webkit-box-shadow: 0px 0px 0px 2px #8ca7c4;
427 box-shadow: 0px 0px 0px 2px #8ca7c4; 468 box-shadow: 0px 0px 0px 2px #8ca7c4;
428 border-radius: 30px; 469 border-radius: 30px;
429 } 470 }
430 471
431 #donate-block span, #share-block span 472 #donate-block span, #share-block span
432 { 473 {
433 margin: 13px 20px 10px 20px; 474 margin: 13px 20px 10px 20px;
(...skipping 13 matching lines...) Expand all
447 border-style: none dashed; 488 border-style: none dashed;
448 width: 50%; 489 width: 50%;
449 } 490 }
450 491
451 #share-block 492 #share-block
452 { 493 {
453 border-right: 1px dashed #37506d; 494 border-right: 1px dashed #37506d;
454 width: 49%; 495 width: 49%;
455 } 496 }
456 497
457 #share-buttons 498 .share-buttons
458 { 499 {
459 margin: 6px 0 0 0; 500 margin: 6px 0 0 0;
460 min-height: 50px;
461 cursor: pointer; 501 cursor: pointer;
462 display: inline-block;
463 vertical-align: top; 502 vertical-align: top;
464
465 /* because inline block creates 503 /* because inline block creates
466 * space if not captured with 504 * space if not captured with
467 * font-size and line-height 0px 505 * font-size and line-height 0px
468 */ 506 */
469 font-size: 0px; 507 font-size: 0px;
470 line-height: 0px; 508 line-height: 0px;
471 } 509 }
472 510
473 #share-buttons > a 511 .share-buttons > a
474 { 512 {
475 width: 50px; 513 width: 50px;
476 height: 50px; 514 height: 50px;
477 margin: 0 8px; 515 margin: 0 8px;
478 text-decoration: none; 516 text-decoration: none;
479 display: inline-block; 517 display: inline-block;
480 } 518 }
481 519
520 html[lang^="zh_"] #share-chinese,
521 html:not([lang^="zh_"]) #share-general
522 {
523 display: block;
524 }
525
526 html[lang^="zh_"] #share-general,
527 html:not([lang^="zh_"]) #share-chinese
528 {
529 display: none;
530 }
531
532 #share-chinese > a
533 {
534 border-bottom: 2px solid transparent;
535 }
536
537 #share-chinese > a:hover
538 {
539 -moz-box-shadow: none;
540 -webkit-box-shadow: none;
541 box-shadow: none;
542 border-radius: 0;
543 border-bottom: 2px solid #8CA7C4;
544 }
545
482 #share-facebook 546 #share-facebook
483 { 547 {
484 background-image: url(social/facebook.png); 548 background-image: url(social/facebook.png);
485 background-repeat: no-repeat; 549 background-repeat: no-repeat;
486 } 550 }
487 551
488 #share-twitter 552 #share-twitter
489 { 553 {
490 background-image: url(social/twitter.png); 554 background-image: url(social/twitter.png);
491 background-repeat: no-repeat; 555 background-repeat: no-repeat;
492 } 556 }
493 557
494 #share-gplus 558 #share-gplus
495 { 559 {
496 background-image: url(social/googleplus.png); 560 background-image: url(social/googleplus.png);
561 background-repeat: no-repeat;
562 }
563
564 #share-renren
565 {
566 background-image: url(social/renren.png);
567 background-repeat: no-repeat;
568 }
569
570 #share-weibo
571 {
572 background-image: url(social/weibo.png);
497 background-repeat: no-repeat; 573 background-repeat: no-repeat;
498 } 574 }
499 575
500 #dataCorruptionWarning 576 #dataCorruptionWarning
501 { 577 {
502 font-size: 160%; 578 font-size: 160%;
503 border: 3px dashed red; 579 border: 3px dashed red;
504 text-align: center; 580 text-align: center;
505 } 581 }
506 582
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 } 707 }
632 708
633 .toggle-on, .toggle-off 709 .toggle-on, .toggle-off
634 { 710 {
635 min-width: 42px; 711 min-width: 42px;
636 height: 100%; 712 height: 100%;
637 font-size: 11px; 713 font-size: 11px;
638 font-weight: 500; 714 font-weight: 500;
639 text-align: center; 715 text-align: center;
640 line-height: 23px; 716 line-height: 23px;
717 border-radius: 9999px;
718 -moz-border-radius: 9999px;
719 -webkit-border-radius: 9999px;
641 } 720 }
642 721
643 .toggle-on 722 .toggle-on
644 { 723 {
645 padding: 0px 30px 0px 10px; 724 padding: 0px 30px 0px 10px;
646 color: rgba(255,255,255, 0.8); 725 color: rgba(255,255,255, 0.8);
647 text-shadow: 1px 1px rgba(0,0,0,0.2); 726 text-shadow: 1px 1px rgba(0,0,0,0.2);
648 box-shadow: inset 2px 2px 6px rgba(0,0,0,0.2); 727 box-shadow: inset 2px 2px 6px rgba(0,0,0,0.2);
649 background: rgb(69,163,31); 728 background: rgb(69,163,31);
650 } 729 }
(...skipping 10 matching lines...) Expand all
661 } 740 }
662 741
663 .toggle-blob 742 .toggle-blob
664 { 743 {
665 position: absolute; 744 position: absolute;
666 top: 0px; 745 top: 0px;
667 right: 0px; 746 right: 0px;
668 height: 100%; 747 height: 100%;
669 width: 22px; 748 width: 22px;
670 border-radius: 50px; 749 border-radius: 50px;
671 box-shadow: 1px 1px 2px #888;
672 background: #cfcfcf; 750 background: #cfcfcf;
673 background: -moz-linear-gradient(bottom, #cfcfcf 0%, #f5f5f5 100%); 751 background: -moz-linear-gradient(bottom, #cfcfcf 0%, #f5f5f5 100%);
674 background: -webkit-linear-gradient(bottom, #cfcfcf 0%,#f5f5f5 100%); 752 background: -webkit-linear-gradient(bottom, #cfcfcf 0%,#f5f5f5 100%);
675 background: linear-gradient(to top, #cfcfcf 0%,#f5f5f5 100%); 753 background: linear-gradient(to top, #cfcfcf 0%,#f5f5f5 100%);
754 box-shadow: 1px 1px 2px #888;
676 } 755 }
677 756
678 .off .toggle-on 757 .off .toggle-on
679 { 758 {
680 margin-top: -22px; 759 margin-top: -22px;
681 } 760 }
682 761
683 .off .toggle-blob 762 .off .toggle-blob
684 { 763 {
685 left: 0px; 764 left: 0px;
(...skipping 17 matching lines...) Expand all
703 font-family: arial, sans-serif; 782 font-family: arial, sans-serif;
704 background-image: url(donate.png); 783 background-image: url(donate.png);
705 background-repeat: repeat-x; 784 background-repeat: repeat-x;
706 } 785 }
707 786
708 footer 787 footer
709 { 788 {
710 margin: 0 auto 30px; 789 margin: 0 auto 30px;
711 max-width: 960px; 790 max-width: 960px;
712 text-align: center; 791 text-align: center;
713 } 792 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld