Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/firstRun.html

Issue 11039060: first run page redesign (Closed)
Patch Set: codereview updates Created Aug. 27, 2013, 1:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/content/ui/firstRun.html
===================================================================
--- a/chrome/content/ui/firstRun.html
+++ b/chrome/content/ui/firstRun.html
@@ -1,103 +1,155 @@
-<!DOCTYPE html>
-<!--
- - This file is part of Adblock Plus <http://adblockplus.org/>,
- - Copyright (C) 2006-2013 Eyeo GmbH
- -
- - Adblock Plus is free software: you can redistribute it and/or modify
- - it under the terms of the GNU General Public License version 3 as
- - published by the Free Software Foundation.
- -
- - Adblock Plus is distributed in the hope that it will be useful,
- - but WITHOUT ANY WARRANTY; without even the implied warranty of
- - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- - GNU General Public License for more details.
- -
- - You should have received a copy of the GNU General Public License
- - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
- -->
-
-<html>
- <head>
- <title class="i18n_firstRun_title"></title>
- <meta charset="utf-8">
- <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/>
- <script type="text/javascript" src="utils.js"></script>
- <script type="text/javascript" src="i18n.js"></script>
- <script type="text/javascript" src="firstRun.js"></script>
- </head>
- <body>
- <div id="shade" class="arrow"></div>
- <div id="content">
- <header>
- <h1 id="title-main" class="i18n_firstRun_title"></h1>
- </header>
-
- <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></p>
-
- <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p>
-
- <h2 id="features-title" class="i18n_firstRun_features"></h2>
-
- <ul id="features">
- <li id="feature-malware" class="feature">
- <div class="feature-image"></div>
- <div class="feature-description">
- <p class="feature-text">
- <span class="i18n_firstRun_feature_malware feature-title"></span> <span class="i18n_firstRun_feature_malware_description"></span>
- </p>
- </div>
- <div id="toggle-malware" class="toggle">
- <div class="i18n_firstRun_toggle_on toggle-on"></div>
- <div class="toggle-blob"></div>
- <div class="i18n_firstRun_toggle_off toggle-off"></div>
- </div>
- </li>
- <li id="feature-social" class="feature">
- <div class="feature-image"></div>
- <div class="feature-description">
- <p class="feature-text">
- <span class="i18n_firstRun_feature_social feature-title"></span> <span class="i18n_firstRun_feature_social_description"></span>
- </p>
- </div>
- <div id="toggle-social" class="toggle">
- <div class="i18n_firstRun_toggle_on toggle-on"></div>
- <div class="toggle-blob"></div>
- <div class="i18n_firstRun_toggle_off toggle-off"></div>
- </div>
- </li>
- <li id="feature-tracking" class="feature">
- <div class="feature-image"></div>
- <div class="feature-description">
- <p class="feature-text">
- <span class="i18n_firstRun_feature_tracking feature-title"></span> <span class="i18n_firstRun_feature_tracking_description"></span>
- </p>
- </div>
- <div id="toggle-tracking" class="toggle">
- <div class="i18n_firstRun_toggle_on toggle-on"></div>
- <div class="toggle-blob"></div>
- <div class="i18n_firstRun_toggle_off toggle-off"></div>
- </div>
- </li>
- </ul>
-
- <footer id="social">
- <h1 class="i18n_firstRun_share"></h1>
- <ul>
- <li>
- <a id="share-facebook" class="share-button" href="https://www.facebook.com/adblockplus" target="_blank" title="Share on Facebook" data-script="https://facebook.com/plugins/like.php?"></a>
- </li>
- <li>
- <a id="share-twitter" class="share-button" href="https://twitter.com/adblockplus" target="_blank" title="Share on Twitter" data-script="https://platform.twitter.com/widgets.js"></a>
- </li>
- <li>
- <a id="share-gplus" class="share-button" href="https://www.google.com/+AdblockPlus" target="_blank" title="Share on Google+" data-script="https://apis.google.com/js/plusone.js"></a>
- </li>
- </ul>
- </footer>
- </div>
-
- <div id="glass-pane">
- <iframe id="share-popup" scrolling="no"></iframe>
- </div>
- </body>
-</html>
+<!DOCTYPE html>
+<!--
+ - This file is part of Adblock Plus <http://adblockplus.org/>,
+ - Copyright (C) 2006-2013 Eyeo GmbH
+ -
+ - Adblock Plus is free software: you can redistribute it and/or modify
+ - it under the terms of the GNU General Public License version 3 as
+ - published by the Free Software Foundation.
+ -
+ - Adblock Plus is distributed in the hope that it will be useful,
+ - but WITHOUT ANY WARRANTY; without even the implied warranty of
+ - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ - GNU General Public License for more details.
+ -
+ - You should have received a copy of the GNU General Public License
+ - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ -->
+
+<html>
+ <head>
+ <title class="i18n_firstRun_title"></title>
+ <meta charset="utf-8">
+ <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/>
+ <script type="text/javascript" src="utils.js"></script>
+ <script type="text/javascript" src="i18n.js"></script>
+ <script type="text/javascript" src="firstRun.js"></script>
+ </head>
+ <body>
+
+
+ <header>
+ <div id="logo"></div>
+ <h1 id="title-main" class="i18n_firstRun_title"></h1>
+ </header>
+
+ <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></section>
+
+
+ <section id="acceptable-ads">
+ <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2>
+ <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p>
+ </section>
+
+ <section id="can-do-more">
+ <h2 class="i18n_firstRun_features"></h2>
+
+ <ul id="can-do-more-overview">
+ <li id="feature-first">
+ <div class="feature-malware-image"></div>
+ <h4 class="i18n_firstRun_feature_malware"></h4>
+ </li>
+ <li>
+ <div class="feature-social-image"></div>
+ <h4 class="i18n_firstRun_feature_social"></h4>
+ </li>
+ <li>
+ <div class="feature-tracking-image"></div>
+ <h4 class="i18n_firstRun_feature_tracking"></h4>
+ </li>
+ </ul>
+
+ <div id="can-do-more-expanded" class="hide fade">
+ <ul id="features">
+ <li id="feature-malware" class="feature">
+ <div class="feature-image feature-malware-image"></div>
+ <div class="feature-description">
+ <div class="feature-description-textblock">
+ <h3 class="i18n_firstRun_feature_malware feature-title"></h3>
+ <span class="i18n_firstRun_feature_malware_description"></span>
+ </div>
+ <div id="toggle-malware" class="toggle">
+ <div class="i18n_firstRun_toggle_on toggle-on"></div>
+ <div class="toggle-blob"></div>
+ <div class="i18n_firstRun_toggle_off toggle-off"></div>
+ </div>
+ </div>
+
+ </li>
+ <li id="feature-social" class="feature">
+ <div class="feature-image feature-social-image"></div>
+ <div class="feature-description">
+ <div class="feature-description-textblock">
+ <h3 class="i18n_firstRun_feature_social feature-title"></h3>
+ <span class="i18n_firstRun_feature_social_description"></span>
+ </div>
+ <div id="toggle-social" class="toggle">
+ <div class="i18n_firstRun_toggle_on toggle-on"></div>
+ <div class="toggle-blob"></div>
+ <div class="i18n_firstRun_toggle_off toggle-off"></div>
+ </div>
+ </div>
+ </li>
+
+ <li id="feature-tracking" class="feature">
+ <div class="feature-image feature-tracking-image"></div>
+ <div class="feature-description">
+ <div class="feature-description-textblock">
+ <h3 class="i18n_firstRun_feature_tracking feature-title"></h3>
+ <span class="i18n_firstRun_feature_tracking_description"></span>
+ </div>
+ <div id="toggle-tracking" class="toggle">
+ <div class="i18n_firstRun_toggle_on toggle-on"></div>
+ <div class="toggle-blob"></div>
+ <div class="i18n_firstRun_toggle_off toggle-off"></div>
+ </div>
+ </div>
+ </li>
+
+ </ul>
+
+ </div>
+
+
+ <div id="activate-features" class="overview" data-status="overview">
+ <div class="arrow"></div>
+ <a id="activate-features-label">
+ <span id="label-show-expanded" class="i18n_firstRun_feature_show_expanded"></span>
+ <span id="label-show-overview" class="i18n_firstRun_feature_show_overview hide"></span>
+ </a>
+
+ <div class="arrow"></div>
+ </div>
+ </section>
+
+ <section id="share">
+ <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
+
+ <div id="donate-block">
+ <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
+ <span id="donate-label" class="i18n_firstRun_donate_label"></span>
+ </div>
+
+ <div id="share-block">
+ <div id="share-buttons">
+ <a id="share-facebook" href="https://www.facebook.com/adblockplus" target="_blank" data-script="https://facebook.com/plugins/like.php?">
+ </a>
+ <a id="share-twitter" href="https://twitter.com/adblockplus" target="_blank" data-script="https://platform.twitter.com/widgets.js">
+ </a>
+ <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_blank" data-script="https://apis.google.com/js/plusone.js">
+ </a>
+ </div>
+ <span class="i18n_firstRun_share"></span>
+ </div>
+ </section>
+
+ <footer>
+ <a id="contributors">Contributor Credits</a>
Wladimir Palant 2013/10/02 13:21:39 This string should be localized.
Wladimir Palant 2013/10/02 13:25:43 Never mind, this is apparently already addressed.
+ </footer>
+
+
+ <div id="glass-pane">
+ <iframe id="share-popup" scrolling="no"></iframe>
+ </div>
+ </body>
+</html>
« no previous file with comments | « build.py ('k') | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')

Powered by Google App Engine
This is Rietveld