Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/prefs.js

Issue 11161031: Show notifications on startup (Chrome) (Closed)
Patch Set: Address issue from the Firefox review Created July 20, 2013, 10:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 15 matching lines...) Expand all
26 patternsbackups: 5, 26 patternsbackups: 5,
27 patternsbackupinterval: 24, 27 patternsbackupinterval: 24,
28 data_directory: "", 28 data_directory: "",
29 savestats: false, 29 savestats: false,
30 privateBrowsing: false, 30 privateBrowsing: false,
31 subscriptions_fallbackerrors: 5, 31 subscriptions_fallbackerrors: 5,
32 subscriptions_fallbackurl: "https://adblockplus.org/getSubscription?version=%V ERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNE LSTATUS%&responseStatus=%RESPONSESTATUS%", 32 subscriptions_fallbackurl: "https://adblockplus.org/getSubscription?version=%V ERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNE LSTATUS%&responseStatus=%RESPONSESTATUS%",
33 subscriptions_autoupdate: true, 33 subscriptions_autoupdate: true,
34 subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/excep tionrules.txt", 34 subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/excep tionrules.txt",
35 documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%" , 35 documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%" ,
36 notificationdata: {}
Wladimir Palant 2013/07/21 11:15:30 What about notificationurl?
Felix Dahlke 2013/07/22 12:30:15 Done.
36 }; 37 };
37 38
38 let listeners = []; 39 let listeners = [];
39 40
40 function defineProperty(key) 41 function defineProperty(key)
41 { 42 {
42 Prefs.__defineGetter__(key, function() 43 Prefs.__defineGetter__(key, function()
43 { 44 {
44 if (key in localStorage) 45 if (key in localStorage)
45 { 46 {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 removeListener: function(listener) 81 removeListener: function(listener)
81 { 82 {
82 let index = listeners.indexOf(listener); 83 let index = listeners.indexOf(listener);
83 if (index >= 0) 84 if (index >= 0)
84 listeners.splice(index, 1); 85 listeners.splice(index, 1);
85 }, 86 },
86 }; 87 };
87 88
88 for (let key in defaults) 89 for (let key in defaults)
89 defineProperty(key); 90 defineProperty(key);
OLDNEW

Powered by Google App Engine
This is Rietveld