Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: notification.js

Issue 11161031: Show notifications on startup (Chrome) (Closed)
Left Patch Set: Addressed issues (except for the animation) Created July 22, 2013, 12:27 p.m.
Right Patch Set: Addressed issues Created July 23, 2013, 12:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « notification.html ('k') | popup.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 notification.onClicked(); 69 notification.onClicked();
70 70
71 var texts = Notification.getLocalizedTexts(notification); 71 var texts = Notification.getLocalizedTexts(notification);
72 var titleElement = document.getElementById("title"); 72 var titleElement = document.getElementById("title");
73 titleElement.textContent = texts.title; 73 titleElement.textContent = texts.title;
74 74
75 var docLinks = getDocLinks(notification); 75 var docLinks = getDocLinks(notification);
76 var messageElement = document.getElementById("message"); 76 var messageElement = document.getElementById("message");
77 insertMessage(messageElement, texts.message, docLinks); 77 insertMessage(messageElement, texts.message, docLinks);
78 78
79 var linkElements = messageElement.getElementsByTagName("a"); 79 messageElement.addEventListener("click", function(event)
80 for (var i = 0; i < linkElements.length; i++)
81 { 80 {
82 var linkElement = linkElements[i]; 81 var link = event.target;
83 linkElement.addEventListener("click", function(event) 82 while (link && link !== messageElement && link.localName !== "a")
84 { 83 link = link.parentNode;
85 event.preventDefault(); 84 if (!link)
86 event.stopPropagation(); 85 return;
87 chrome.tabs.create({url: linkElement.href}); 86 event.preventDefault();
88 }); 87 event.stopPropagation();
89 } 88 chrome.tabs.create({url: link.href});
Wladimir Palant 2013/07/22 14:18:36 So this loop is only there to attach event listene
Felix Dahlke 2013/07/22 15:10:22 Yes, that would also work. Note that we have prett
Wladimir Palant 2013/07/23 07:25:04 Sure, it should be changed there as well.
Felix Dahlke 2013/07/23 10:38:08 Done.
89 });
90 90
91 var notificationElement = document.getElementById("notification"); 91 var notificationElement = document.getElementById("notification");
92 notificationElement.className = notification.severity; 92 notificationElement.className = notification.severity;
93 notificationElement.style.display = "block"; 93 notificationElement.style.display = "block";
94 }); 94 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld