Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/sendReport.js

Issue 11172012: Issue reporter: include version number of the filter subscription in the data (Closed)
Patch Set: Created July 18, 2013, 9:47 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/sendReport.js
===================================================================
--- a/chrome/content/ui/sendReport.js
+++ b/chrome/content/ui/sendReport.js
@@ -293,16 +293,18 @@ let subscriptionsDataSource =
let subscription = FilterStorage.subscriptions[i];
if (!this.subscriptionFilter(subscription))
continue;
let subscriptionXML = appendElement(subscriptions, "subscription", {
id: subscription.url,
disabledFilters: subscription.filters.filter(function(filter) filter instanceof ActiveFilter && filter.disabled).length
});
+ if (subscription.version)
+ subscriptionXML.setAttribute("version", subscription.version);
if (subscription.lastDownload)
subscriptionXML.setAttribute("lastDownloadAttempt", subscription.lastDownload - now);
if (subscription instanceof DownloadableSubscription)
{
if (subscription.lastSuccess)
subscriptionXML.setAttribute("lastDownloadSuccess", subscription.lastSuccess - now);
if (subscription.softExpiration)
subscriptionXML.setAttribute("softExpiration", subscription.softExpiration - now);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld