FRP wrappers. "Update" menu item.

html/static/js/ieFirstRun.js

+var AdblockPlus = {
+        require: function(param)
+        {
+                if (param == "prefs")
+                {
+                        return {
+                                Prefs: 
+                                {
+                                        documentation_link: ""
+                                }
+                        }
+                }
+                if (param == "utils")
+                {
+                        return {
+                                Utils: 
+                                {
+                                        appLocale: ""
+                                }
+                        }
+                }
+                if (param == "filterClasses")
+                {
+                        return {
+                                Filter: 
+                                {
+                                        fromText: function(param) 
+                                        { 
+                                                return {
+                                                        matches: function(param) {
+                                                                return true; 
+                                                        } 
+                                                }
+                                        } 
+                                }
+                        }
+                }
+                return {};
+        }
+}
+
+function initWrappers()
+{
+        AdblockPlus.getMessage = function(section, param)
+        {
+                return Settings.GetMessage(section, param);
+        }
+        Prefs.documentation_link = Settings.GetDocumentationLink();
+        Utils.appLocale = Settings.GetAppLocale();

[Wladimir Palant, 2013/08/13 09:19:51]

This seems to assume that the result of require("prefs") is assigned to a global
Prefs variable where it can be accessed. Also, there is an assumption that this
result won't be used before the page load event.

I guess that the problem here is that the Settings object isn't available while
the page is loading? Then we cannot help the objects being uninitialized while
the page is being loaded. However, assuming global variables is completely
unnecessary. Please consider the following approach:

var AdblockPlus = (function()
{
  var scopes = {
    prefs: {
      Prefs: { documentation_link: "" }
    },
    ...
  };

  var result = {
    require: function(module)
    {
      return scopes[module];
    }
  };

  window.addEventListener("load", function()
  {
    result.getMessage = Settings.GetMessage;
    scopes.prefs.Prefs.documentation_link = Settings.GetDocumentationLink();
    ...
  }, false);

  return result;
})();

Wrapping everything inside a function ensures that only the AdblockPlus variable
is touched in the global scope - all other variables are defined locally and can
be accessed from that function only.

+}
+
+window.addEventListener("load", initWrappers, false);