Disable everywhere fix

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
@@ skipping 169 matching lines @@
   m_dwWorkingThreadId = ::GetCurrentThreadId();
 }
 
 void CPluginSettings::SetWorkingThreadId(DWORD id)
 {
   m_dwWorkingThreadId = id;
 }
 
 void CPluginSettings::TogglePluginEnabled()
 {
-  GetPluginEnabled() ? SetPluginDisabled() : SetPluginEnabled();   

[Wladimir Palant, 2013/08/13 14:25:29]

The SetPluginEnabled/SetPluginDisabled functions are only used here. This means
that we could just as well do the following and save some code:

  CPluginClient::GetInstance()->SetPref(L"enabled", !GetPluginEnabled());

Still, this requires two calls to the engine where one would be sufficient
(never mind the race condition) - I would prefer to do a single "toggle" call
and let the engine check the current state of the pref.

Both issues can be fixed after the release I guess...

-}
-void CPluginSettings::SetPluginDisabled()
-{
-  CPluginClient::GetInstance()->SetPref(L"enabled", false);  
-}
-void CPluginSettings::SetPluginEnabled()
-{
-  CPluginClient::GetInstance()->SetPref(L"enabled", true);
+  CPluginClient::GetInstance()->TogglePluginEnabled();  
 }
 bool CPluginSettings::GetPluginEnabled() const
 {
   return CPluginClient::GetInstance()->GetPref(L"enabled", true);
 }
 
 
 void CPluginSettings::AddError(const CString& error, const CString& errorCode)
 {
   DEBUG_SETTINGS(L"SettingsTab::AddError error:" + error + " code:" + errorCode)
@@ skipping 130 matching lines @@
 }
 
 CString CPluginSettings::GetDocumentationLink()
 {
   return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
 }
 
 
 
 #endif // SUPPORT_WHITELIST