packagerGecko.py - Issue 11544056: Prepared buildtools for Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: packagerGecko.py

Issue 11544056: Prepared buildtools for Safari (Closed)

Left Patch Set: Addressed comments Created Oct. 30, 2013, 5:22 p.m.

Right Patch Set: Created Oct. 31, 2013, 3:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 # coding: utf-8	1 # coding: utf-8

2	2

3 # This file is part of the Adblock Plus build tools,	3 # This file is part of the Adblock Plus build tools,

4 # Copyright (C) 2006-2013 Eyeo GmbH	4 # Copyright (C) 2006-2013 Eyeo GmbH

5 #	5 #

6 # Adblock Plus is free software: you can redistribute it and/or modify	6 # Adblock Plus is free software: you can redistribute it and/or modify

7 # it under the terms of the GNU General Public License version 3 as	7 # it under the terms of the GNU General Public License version 3 as

8 # published by the Free Software Foundation.	8 # published by the Free Software Foundation.

9 #	9 #

10 # Adblock Plus is distributed in the hope that it will be useful,	10 # Adblock Plus is distributed in the hope that it will be useful,

(...skipping 311 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
322 files['install.rdf'] = createManifest(params)	322 files['install.rdf'] = createManifest(params)

323 if metadata.has_section('mapping'):	323 if metadata.has_section('mapping'):

324 files.readMappedFiles(metadata.items('mapping'))	324 files.readMappedFiles(metadata.items('mapping'))

325 files.read(baseDir, skip=('chrome'))	325 files.read(baseDir, skip=('chrome'))

326 for name, path in getChromeSubdirs(baseDir, params['locales']).iteritems():	326 for name, path in getChromeSubdirs(baseDir, params['locales']).iteritems():

327 if os.path.isdir(path):	327 if os.path.isdir(path):

328 files.read(path, 'chrome/%s' % name)	328 files.read(path, 'chrome/%s' % name)

329 fixupLocales(params, files)	329 fixupLocales(params, files)

330 if not 'bootstrap.js' in files:	330 if not 'bootstrap.js' in files:

331 addMissingFiles(params, files)	331 addMissingFiles(params, files)

	332 if metadata.has_section('preprocess'):

	333 files.preprocess([f for f, _ in metadata.items('preprocess')])

332 if keyFile:	334 if keyFile:

333 signFiles(files, keyFile)	335 signFiles(files, keyFile)

334 files.zip(outFile, sortKey=lambda x: '!' if x == 'META-INF/zigbert.rsa' else x )	336 files.zip(outFile, sortKey=lambda x: '!' if x == 'META-INF/zigbert.rsa' else x )

335	337

336 def autoInstall(baseDir, type, host, port, multicompartment=False):	338 def autoInstall(baseDir, type, host, port, multicompartment=False):

337 fileBuffer = StringIO()	339 fileBuffer = StringIO()

338 createBuild(baseDir, type=type, outFile=fileBuffer, multicompartment=multicomp artment)	340 createBuild(baseDir, type=type, outFile=fileBuffer, multicompartment=multicomp artment)

339 urllib.urlopen('http://%s:%s/' % (host, port), data=fileBuffer.getvalue())	341 urllib.urlopen('http://%s:%s/' % (host, port), data=fileBuffer.getvalue())

LEFT	RIGHT