Tooltip notification. Check for update fixes.

src/plugin/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 
 #include "AdblockPlusClient.h"
@@ skipping 423 matching lines @@
     DEBUG_GENERAL((L"GetPref: " + name + L" end").c_str());
     return value;
   }
   else
   {
     DEBUG_GENERAL((L"GetPref: " + name + L" end").c_str());
     return defaultValue;
   }
 }
 
-void CAdblockPlusClient::CheckForUpdates()
+void CAdblockPlusClient::CheckForUpdates(HWND callbackWindow)
 {
-  CallEngine(Communication::PROC_CHECK_FOR_UPDATES);
+  Communication::OutputBuffer request;
+  request << Communication::PROC_CHECK_FOR_UPDATES << (int32_t&)callbackWindow;

[Wladimir Palant, 2013/09/11 13:07:06]

Please use static_cast here.

[Oleksandr, 2013/09/16 13:52:46]

Since we are STRICT compliant: 
http://msdn.microsoft.com/en-us/library/windows/desktop/aa383731(v=vs.85).aspx)
HWND isn't actually a pointer, but rather a struct:

#define DECLARE_HANDLE(name) struct name##__{int unused;}; typedef struct
name##__ *name
So static_cast can't deal with it, and it's actually reinterpret_cast that this
C-style cast resorts to. I can state reinterpret_cast explicitly, but I think
current is a more portable solution. 

[Wladimir Palant, 2013/09/16 14:37:18]

Felix seems to think that generally avoiding C-style casts is a good idea and I
tend to agree.

[Oleksandr, 2013/09/25 10:03:14]

I agree with that as well, but in this case it is already a worst case scenario
(ie we are using reinterpret_cast anyway). So there is no harm in using the
C-style cast, and it increases readability, imho. 
On 2013/09/16 14:37:18, Wladimir Palant wrote:

[Wladimir Palant, 2013/09/25 10:27:14]

I disagree. Currently there are lots of C-style casts in the codebase and there
is no way of recognizing whether they have been used mindlessly or because
reinterpret_cast would need to be used anyway. The only way to change this is
using reinterpret_cast when you mean reinterpret_cast.

+  CallEngine(request);
 }
 
 std::wstring CAdblockPlusClient::GetDocumentationLink()
 {
   DEBUG_GENERAL("GetDocumentationLink");
   Communication::InputBuffer response;
   if (!CallEngine(Communication::PROC_GET_DOCUMENTATION_LINK, response)) 
     return L"";
   std::wstring docLink;
   response >> docLink;
   return docLink;
 }
 
 bool CAdblockPlusClient::TogglePluginEnabled()
 {
   DEBUG_GENERAL("TogglePluginEnabled");
   Communication::InputBuffer response;
   if (!CallEngine(Communication::PROC_TOGGLE_PLUGIN_ENABLED, response)) 
     return false;
   bool currentEnabledState;
   response >> currentEnabledState;
   return currentEnabledState;
 }