Tooltip notification. Check for update fixes.

src/plugin/NotificationMessage.cpp

 #include <Windows.h>
 #include <CommCtrl.h>
 
 #include "NotificationMessage.h"
 
-NotificationMessage::NotificationMessage()
-{
-  toolTipWindow = 0;
-  InitializeCommonControls();
-}
-
-NotificationMessage::NotificationMessage(HWND parent)

[Wladimir Palant, 2013/09/25 14:00:44]

You can merge the two constuctors by specifying 0 as default value for the
parent parameter.

+NotificationMessage::NotificationMessage(HWND parent): parentWindow(parent)
 { 
-  parentWindow = parent;
   toolTipWindow = 0;
   InitializeCommonControls();
 };
 
 bool NotificationMessage::commonControlsInitialized(false);
 
 void NotificationMessage::InitializeCommonControls()
 {
   if (!commonControlsInitialized)
   {
@@ skipping 13 matching lines @@
   }
   toolTipWindow = CreateWindowEx(WS_EX_TOPMOST, TOOLTIPS_CLASS, NULL,
                                   TTS_NOPREFIX | TTS_BALLOON | TTS_CLOSE,
                                   0, 0,
                                   0, 0,
                                   parentWindow, NULL, NULL,
                                   NULL);
 
   SetWindowPos(toolTipWindow, HWND_TOPMOST,0, 0, 0, 0,
           SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE);
-  TOOLINFOW ti;
+  TOOLINFOW ti = {};
   ti.cbSize = sizeof(TOOLINFOW);
   ti.uFlags = TTF_IDISHWND | TTF_TRACK | TTF_TRANSPARENT;
   ti.hwnd = toolTipWindow;
   ti.hinst = NULL;
   ti.uId = (UINT_PTR)parentWindow;
-  ti.lpszText = const_cast<LPWSTR>(message.c_str());    
+  ti.lpszText = const_cast<LPWSTR>(message.c_str());
   GetClientRect(parentWindow, &ti.rect);
 
   LRESULT res = ::SendMessage(toolTipWindow, TTM_ADDTOOL, 0, (LPARAM)&ti);
 
   RECT rect;
   GetWindowRect(parentWindow, &rect);
   Move(rect.left + (rect.right - rect.left) / 2, rect.top + (rect.bottom - rect.top) / 2); 
 
-  res = ::SendMessage(toolTipWindow, TTM_SETTITLE, icon, (LPARAM)title.c_str());

[Wladimir Palant, 2013/09/25 14:00:44]

Not sure where my comment on the previous changeset went but IMHO the code
duplication here needs to be removed by calling SetTextAndIcon().

+  SetTextAndIcon(message, title, icon);
   res = ::SendMessage(toolTipWindow, TTM_TRACKACTIVATE, TRUE, (LPARAM)&ti);
 
   return true;
 }
 
-bool NotificationMessage::Hide()
+void NotificationMessage::Hide()
 {
-  if (IsVisible())

[Wladimir Palant, 2013/09/25 14:00:44]

This seems to be the wrong check to me - we want to check toolTipWindow instead.
We should destroy it even if it isn't visible. You probably do it like this for
the sake of the return value but that return value isn't useful and can be
dropped IMHO.

+  if (toolTipWindow != 0)
   {
     DestroyWindow(toolTipWindow);
     toolTipWindow = 0;
-    return true;
-  }
-  else
-  {
-    return false;
   }
 }
 
 void NotificationMessage::Move(short x, short y)
 {
   ::SendMessage(toolTipWindow, TTM_TRACKPOSITION, 0, MAKELONG(x, y));
   return;
 }
 
 bool NotificationMessage::SetTextAndIcon(std::wstring text, std::wstring title, int icon)
 {
-  TOOLINFOW ti;
+  TOOLINFOW ti = {};
   ti.cbSize = sizeof(TOOLINFOW);
-  ti.uFlags = TTF_IDISHWND | TTF_TRACK | TTF_TRANSPARENT;
   ti.hwnd = toolTipWindow; 
   ti.hinst = NULL;
   ti.uId = (UINT_PTR)parentWindow;
   ti.lpszText = const_cast<LPWSTR>(text.c_str());   
-  GetClientRect(parentWindow, &ti.rect);
   LRESULT res = ::SendMessage(toolTipWindow, TTM_SETTITLE, icon, (LPARAM)title.c_str());
   res = ::SendMessage(toolTipWindow, TTM_UPDATETIPTEXT, 0, (LPARAM)&ti);
   return res == TRUE;
 }
 
 void NotificationMessage::SetParent(HWND parent)
 {
   parentWindow = parent;
 }
 
 bool NotificationMessage::IsVisible()
 {
   if (toolTipWindow == 0)
     return false;
   return IsWindowVisible(toolTipWindow);
 }