Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: icons/abp-19-whitelisted.png
Issue
16067002
:
Added Safari Support (Closed)
Patch Set: Added missing copyright disclaimers and websql implementation
Created Oct. 23, 2013, 2:46 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Added missing copyright disclaimers and websql implementation
Patch Set 3: Rebased on upstream and addressed comments
Patch Set 4: Fixed some bug introduced by rebasing, and fix absolute URLs on extension pages in Safari with JS.
Patch Set 5: Removed absolute URL fix for Safari (this is done by the buildtools now), introduced browser specif…
Patch Set 6: Made description for Safari long again. The 100 char limit given by the extension builder doesn't a…
Patch Set 7: Rebased and changed icon to 16px (for Safari) and 19px again (for Chrome)
Patch Set 8: Converted new calls to chrome.* to ext.* and fixed issue with background page proxy about added/rem…
Patch Set 9:
Patch Set 10: Addressed comments
Patch Set 11: Fixed js errors in popup.html.
Patch Set 12: Addressed comments
Patch Set 13: Adressed comments
Patch Set 14: Bugfixes
Right:
Patch Set 1: None
Patch Set 2: Added missing copyright disclaimers and websql implementation
Patch Set 3: Rebased on upstream and addressed comments
Patch Set 4: Fixed some bug introduced by rebasing, and fix absolute URLs on extension pages in Safari with JS.
Patch Set 5: Removed absolute URL fix for Safari (this is done by the buildtools now), introduced browser specif…
Patch Set 6: Made description for Safari long again. The 100 char limit given by the extension builder doesn't a…
Patch Set 7: Rebased and changed icon to 16px (for Safari) and 19px again (for Chrome)
Patch Set 8: Converted new calls to chrome.* to ext.* and fixed issue with background page proxy about added/rem…
Patch Set 9:
Patch Set 10: Addressed comments
Patch Set 11: Fixed js errors in popup.html.
Patch Set 12: Addressed comments
Patch Set 13: Adressed comments
Patch Set 14: Bugfixes
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgsubstate
background.js
block.js
chrome/background.js
chrome/common.js
chrome/content.js
icons/abp-18.png
icons/abp-18-notification-critical.png
icons/abp-18-notification-information.png
icons/abp-19.png
icons/abp-19-whitelisted.png
icons/notification-critical.png
icons/notification-information.png
include.postload.js
include.preload.js
lib/utils.js
lib/websql/io.js
metadata.chrome
metadata.common
metadata.safari
notification.js
options.html
options.js
popup.html
popup.js
popupBlocker.js
safari/background.js
safari/common.js
safari/content.js
utils.js
webrequest.js
View unified diff
|
Download patch
« chrome/common.js
('K') |
« icons/abp-19.png
('k') |
icons/notification-critical.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« chrome/common.js
('K') |
« icons/abp-19.png
('k') |
icons/notification-critical.png »
('j') |
no next file with comments »
Edit Message
Issue 16067002: Added Safari Support (Closed)
Created Oct. 21, 2013, 8:11 p.m. by Sebastian Noack
Modified Jan. 20, 2014, 12:44 p.m.
Reviewers: Felix Dahlke, Wladimir Palant
Base URL:
Comments: 113
This is Rietveld