Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: iconAnimation.js

Issue 16067002: Added Safari Support (Closed)
Left Patch Set: Made description for Safari long again. The 100 char limit given by the extension builder doesn't a… Created Oct. 31, 2013, 2:12 p.m.
Right Patch Set: Bugfixes Created Nov. 15, 2013, 8:58 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/content.js ('k') | icons/abp-16-notification-critical.png » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 _updateIcon: function(tab) 115 _updateIcon: function(tab)
116 { 116 {
117 var path = this._icons.get(tab); 117 var path = this._icons.get(tab);
118 118
119 if (!path) 119 if (!path)
120 return; 120 return;
121 121
122 if (this._step > 0) 122 if (this._step > 0)
123 { 123 {
124 var suffix = "-notification-" + this._severity; 124 var suffix = "-notification-" + this._severity;
125 125
126 if (this._step < 10) 126 if (this._step < 10)
127 suffix += "-" + this._step; 127 suffix += "-" + this._step;
128 128
129 path = path.replace(/(?=\..+$)/, suffix); 129 path = path.replace(/(?=\..+$)/, suffix);
130 } 130 }
131 131
132 tab.pageAction.setIcon(path); 132 tab.pageAction.setIcon(path);
133 } 133 }
134 }; 134 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld