Construct frame hierarchy using first request originating from it

webrequest.js

Index: webrequest.js
===================================================================
--- a/webrequest.js
+++ b/webrequest.js
@@ -65,8 +65,9 @@
   if (details.frameId == 0 && !(details.tabId in frames) && type == "object")
     type = "main_frame";
 
-  if (type == "main_frame" || type == "sub_frame")
-    recordFrame(details.tabId, details.frameId, details.parentFrameId, details.url);
+  var isFrame = (type == "main_frame" || type == "sub_frame");
+  if (!(details.tabId in frames && details.frameId in frames[details.tabId]))
+    recordFrame(details.tabId, details.frameId, details.parentFrameId, isFrame ? details.url : null);

[Wladimir Palant, 2013/11/06 15:23:14]

Frame URLs can change - a different URL can load into the same frame. So we
should *always* call recordFrame() for main_frame and sub_frame requests. Also,
the URL of your newly added frame should be inherited from the parent frame
(that's what our Firefox version does from about:blank anda data: frames),
setting it to the request made is wrong.

So I would actually keep the original code here and add an else clause:

else if (details.tabId in frames && !(details.frameId in frames[details.tabId]))
  recordFrame(details.tabId, details.frameId, details.parentFrameId, null);

And in recordFrame(), instead of your change:

if (frameUrl == null)
{
  if (tabId in frames && parentFrameId in frames[tabId])
    frameUrl = frames[tabId][parentFrameId].url;
  else
    return;  // We cannot do anything meaningful here
}

 
   if (type == "main_frame")
     return {};
@@ -147,7 +148,8 @@
 {
   if (!(tabId in frames))
     frames[tabId] = {};
-  frames[tabId][frameId] = {url: frameUrl, parent: parentFrameId};
+  else if (!(frameId in frames[tabId]))
+    frames[tabId][frameId] = {url: frameUrl, parent: parentFrameId};
 }
 
 function getFrameData(tabId, frameId)