Delta Between Two Patch Sets: popup.html
Issue 29317001:
Relocated icon and redesigned icon popup (Closed)
Left Patch Set: Applied Sebastian's suggestions and updated strings
Created Nov. 26, 2013, 4:18 p.m.
Right Patch Set: Merged setBadgeNumber and setBadgeBackgroundColor
Created Dec. 13, 2013, 10:36 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/stats.js ('K')
|
« notification.js ('k')
|
popup.js » ('j')
|
skin/popup.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <!-- | 3 <!-- |
| 4 - This file is part of Adblock Plus <http://adblockplus.org/>, | 4 - This file is part of Adblock Plus <http://adblockplus.org/>, |
| 5 - Copyright (C) 2006-2013 Eyeo GmbH | 5 - Copyright (C) 2006-2013 Eyeo GmbH |
| 6 - | 6 - |
| 7 - Adblock Plus is free software: you can redistribute it and/or modify | 7 - Adblock Plus is free software: you can redistribute it and/or modify |
| 8 - it under the terms of the GNU General Public License version 3 as | 8 - it under the terms of the GNU General Public License version 3 as |
| 9 - published by the Free Software Foundation. | 9 - published by the Free Software Foundation. |
| 10 - | 10 - |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 31 <body tabindex="1"> | 31 <body tabindex="1"> |
| 32 | 32 |
| 33 <header> | 33 <header> |
| 34 <div id="logo"></div> | 34 <div id="logo"></div> |
| 35 </header> | 35 </header> |
| 36 | 36 |
| 37 <div id="wrapper"> | 37 <div id="wrapper"> |
| 38 <div id="notification"> | 38 <div id="notification"> |
| 39 <h1> | 39 <h1> |
| 40 <span id="notification-title"></span> | 40 <span id="notification-title"></span> |
| 41 <div id="close-notification"></div> | 41 <span id="close-notification"></span> |
|
Wladimir Palant
2013/12/03 12:55:43
This is an inline element, better use <span>.
| |
| 42 </h1> | 42 </h1> |
| 43 <div id="notification-message"></div> | 43 <div id="notification-message"></div> |
| 44 </div> | 44 </div> |
| 45 | 45 |
| 46 <div id="clickhide-instructions" class="i18n_clickhide_instructions"></div> | 46 <div id="clickhide-instructions" class="i18n_clickhide_instructions"></div> |
| 47 | 47 |
| 48 <ul id="menu"> | 48 <ul id="menu"> |
| 49 <li id="enabled" class="menu-item" role="button"> | 49 <li id="enabled" class="menu-item" role="button"> |
| 50 <div class="icon"></div> | 50 <div class="icon"></div> |
| 51 <span id="enabled-on" class="i18n_enabled_for_site"></span> | 51 <span id="enabled-yes" class="i18n_enabled_for_site"></span> |
| 52 <span id="enabled-off" class="i18n_disabled_for_site"></span> | 52 <span id="enabled-no" class="i18n_disabled_for_site"></span> |
| 53 </li> | 53 </li> |
| 54 | 54 |
| 55 <li id="clickhide" class="menu-item" role="button"> | 55 <li id="clickhide" class="menu-item" role="button"> |
| 56 <div class="icon"></div> | 56 <div class="icon"></div> |
| 57 <span class="i18n_easy_create_filter"></span> | 57 <span class="i18n_easy_create_filter"></span> |
| 58 </li> | 58 </li> |
| 59 <li id="clickhide-cancel" class="menu-item" role="button"> | 59 <li id="clickhide-cancel" class="menu-item" role="button"> |
| 60 <div class="icon"></div> | 60 <div class="icon"></div> |
| 61 <span class="i18n_cancel"></span> | 61 <span class="i18n_cancel"></span> |
| 62 </li> | 62 </li> |
| 63 | 63 |
| 64 <li id="stats-container"> | 64 <li id="stats-container"> |
| 65 <div class="menu-item collapse" data-option="show_popupstats" data-collaps able="stats-container" role="button"> | 65 <div class="menu-item collapse" data-option="show_statsinpopup" data-colla psable="stats-container" role="button"> |
| 66 <div class="icon"></div> | 66 <div class="icon"></div> |
| 67 <span class="i18n_stats_title"></span> | 67 <span class="i18n_stats_title"></span> |
| 68 <div class="collapse-icon"></div> | 68 <div class="collapse-icon"></div> |
| 69 </div> | 69 </div> |
| 70 <ul id="stats" class="collapsable"> | 70 <ul id="stats" class="collapsable"> |
| 71 <li> | 71 <li> |
| 72 <div> | 72 <div> |
| 73 <div id="stats-page"></div> | 73 <div id="stats-page"></div> |
| 74 <div id="stats-total"></div> | 74 <div id="stats-total"></div> |
| 75 </div> | 75 </div> |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 92 </ul> | 92 </ul> |
| 93 </div> | 93 </div> |
| 94 | 94 |
| 95 <footer id="options" role="button"> | 95 <footer id="options" role="button"> |
| 96 <div class="icon"></div> | 96 <div class="icon"></div> |
| 97 <span class="i18n_options_short"></span> | 97 <span class="i18n_options_short"></span> |
| 98 </footer> | 98 </footer> |
| 99 | 99 |
| 100 </body> | 100 </body> |
| 101 </html> | 101 </html> |
| LEFT | RIGHT |
« notification.js ('k')
|
popup.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
