Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: background.js

Issue 29321198: Issue 2376 - Implement custom filters in new options page (Closed)
Patch Set: Added param to readme and some fixes Created July 15, 2015, 10:36 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« README.md ('K') | « README.md ('k') | locale/en-US/options.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -153,6 +153,26 @@
return new modules.filterClasses.Filter(text);
};
+ var validation = {filterError: false};
Sebastian Noack 2015/07/15 11:20:00 I wonder whether it would make more sense meanwhil
Thomas Greiner 2015/07/15 11:31:40 They're all globally accessible anyway and don't c
saroyanm 2015/07/15 12:06:52 Done.
+ updateFromURL(validation);
+ modules.filterValidation =
+ {
+ parseFilter: function(text)
+ {
+
+ if (validation.filterError)
+ return {error: "filter-parsing-error"};
+ return {filter: modules.filterClasses.Filter.fromText(text)};
+ },
+ parseFilters: function(text)
+ {
+ if (validation.filterError)
+ return {errors: ["filter-parsing-error"]};
+ return {filters:
+ text.split("\n").map(modules.filterClasses.Filter.fromText)};
+ }
+ };
+
modules.synchronizer = {
Synchronizer: {}
};
@@ -221,7 +241,23 @@
"@@||alternate.de^$document",
"@@||der.postillion.com^$document",
"@@||taz.de^$document",
- "@@||amazon.de^$document"
+ "@@||amazon.de^$document",
+ "||biglemon.am/bg_poster/banner.jpg",
+ "winfuture.de###header_logo_link",
+ "###WerbungObenRechts10_GesamtDIV",
+ "###WerbungObenRechts8_GesamtDIV",
+ "###WerbungObenRechts9_GesamtDIV",
+ "###WerbungUntenLinks4_GesamtDIV",
+ "###WerbungUntenLinks7_GesamtDIV",
+ "###WerbungUntenLinks8_GesamtDIV",
+ "###WerbungUntenLinks9_GesamtDIV",
+ "###Werbung_Sky",
+ "###Werbung_Wide",
+ "###__ligatus_placeholder__",
+ "###ad-bereich1-08",
+ "###ad-bereich1-superbanner",
+ "###ad-bereich2-08",
+ "###ad-bereich2-skyscrapper"
];
var knownFilters = filters.map(modules.filterClasses.Filter.fromText);
« README.md ('K') | « README.md ('k') | locale/en-US/options.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld