Issue 2744 - Install correct version of JS shell for 64bit Linux

utils.py

Index: utils.py
diff --git a/utils.py b/utils.py
index 6fdd8b4f758696c587cace041cedaff5b7b973a1..ac3014ae675e7cf67fd33965c7f4f5a2eb13195b 100644
--- a/utils.py
+++ b/utils.py
@@ -4,8 +4,12 @@
 # version 2.0 (the "License"). You can obtain a copy of the License at
 # http://mozilla.org/MPL/2.0/.
 
-import sys, os, urllib, zipfile
+import os
+import platform
 from StringIO import StringIO
+import sys
+import urllib
+import zipfile
 
 def ensureJSShell():
   baseDir = os.path.dirname(__file__)
@@ -19,15 +23,24 @@ def ensureJSShell():
   if os.path.exists(path):
     return path
 
-  platform_map = {
+  supported_platforms = {
     'win32': 'win32',
-    'linux2': 'linux-i686',
+    'linux2': {

[Sebastian Noack, 2015/07/03 14:31:44]

How about following?

supported_platforms = {
  ...
  'linux2': 'linux-%(arch)s'
  ...
}
...

build = supported_platforms[sys.platform] % {arch: platform.machine()}

[kzar, 2015/07/03 14:37:22]

I did consider doing something like that but I think it's better to explicitly
define the supported architectures. There aren't any other Linux builds of JS
shell available. 

[Sebastian Noack, 2015/07/03 14:41:34]

This is a good point. However, I don't like introducing a special case here, but
don't have a better idea right now. So LGTM.

+      'i686': 'linux-i686',
+      'x86_64': 'linux-x86_64'
+    },
     'darwin': 'mac',
   }
-  if sys.platform not in platform_map:
-    raise Exception('Unknown platform, is there a JS shell version for it?')
-
-  download_url = 'https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/02/2015-02-25-00-22-19-mozilla-esr31/jsshell-%s.zip' % platform_map[sys.platform]
+  try:
+    build = supported_platforms[sys.platform]
+    if isinstance(build, dict):
+      build = build[platform.machine()]
+  except KeyError:
+    raise Exception('Platform %s (%s) not supported by JS shell' % (
+      sys.platform, platform.machine()
+    ))
+
+  download_url = 'https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/02/2015-02-25-00-22-19-mozilla-esr31/jsshell-%s.zip' % build
   data = StringIO(urllib.urlopen(download_url).read())
   zip = zipfile.ZipFile(data)
   zip.extractall(shell_dir)