Issue 2844 - Create Microsoft Edge coming soon landing page

includes/index.tmpl

Index: includes/index.tmpl
===================================================================
--- a/includes/index.tmpl
+++ b/includes/index.tmpl
@@ -65,6 +65,23 @@
           <div class="sprite"></div>
 {{"Integrated by default in"|translate("s11")}} <a href="http://www.maxthon.com/" target="_blank">{{"Maxthon Cloud Browser"|translate("s12")}}</a>
         </li>
+        <li id="feature-edge" itemprop="featureList">

[saroyanm, 2015/09/22 13:15:45]

It's not part of the feature block, so please move it to it's own block between
"features" and "install" block, you can give it more specific ID and access
Form, Button and textbox through that block. Ex.: edge-subscription.
So you will access the mentioned elements like: "#edge-subscription form",
"#edge-subscription button" (or if you want to be more specific than you can use
"#edge-subscription button[type=submit]") and "#edge-subscription input".

[Oleksandr, 2015/09/23 00:37:57]

I agree that it makes sense to move this away from the UL, however I don't see
how would getting rid of the IDs be useful. We used IDs in for the iOS
subscription page, and if we remove them here, there will be a lot of
querySelector calls in JavaScript in index.js, which is slower and less
intuitive, IMO.

[saroyanm, 2015/09/23 12:44:20]

My point was about CSS actually, but still.
I can see several reason why I'd prefer not use ID for each element here, beside
that It's not good experience to assign ID to each element IMO: 
1. It will minimize the risk of ID duplication
2. You can reuse the styles for the child elements for future forms on homepage
(well this point is not related, but when you have IDs people intentionally can
try assign styles to IDs)
3. You can reuse the function for future forms on the page, otherwise we will
need to modify current implementation and retest it, which can lead to errors in
future.
Yes we used IDs, but the page wasn't so complex, you can use edge block to
related to child elements and use getElementsByTagName and
getElementsByClassName, shouldn't harm the performance that much, beside that
the  script will be executed on submission, the only script that will run before
submission is the placeholder hack for old browsers, so we are covering most
cases IMO, so performance wise we are okey here.

+          <p class="subscribe-description">

[saroyanm, 2015/09/22 13:15:45]

It's probably not description and even you can and also I'd more consider it as
a heading the edge block, so you can use heading here and remove class
attribute.

+            {{"Get a heads-up prior to the launch!"|translate("subscription-description")}}
+          </p>
+          <form id="subscribe-form" accept-charset="utf-8" action="/submitEmail" method="post">

[saroyanm, 2015/09/22 13:15:45]

If you will do changes mentioned above you will not need this generic ID
assigned to the form, to the button and to the inputbox.

+            <input id="subscribe-textbox" type="email" name="email" placeholder="{{"Your email address"|translate("subscription-input-placeholder")}}" required />
+            <button id="subscribe-button" type="submit"><span>{{"Notify me"|translate("subscription-button")}}</span></button>
+            <span class="sucess-label">
+              {{"A confirmation email has been sent. Please check your email and click the confirmation link."|translate("subscription-message-success")}}
+            </span>
+            <span class="invalid-label">
+              {{"Please enter a valid email address."|translate("subscription-message-invalid-email")}}
+            </span>
+            <span id="response-error">

[saroyanm, 2015/09/22 13:15:45]

I'd use class here as well, so it can be applied to other forms on current page
and will be consistent with the previous comments I've made.

+            </span>
+          </form>
+      </li>
       </ul>
     </div>
 
@@ -76,6 +93,7 @@
       <a class="install-button" href="https://update.adblockplus.org/latest/adblockplusie.exe" id="install-internet-explorer">{{"Install for Internet Explorer"|translate("s17")}}</a>
       <a class="install-button" href="https://update.adblockplus.org/latest/adblockplussafari.safariextz" id="install-safari">{{"Install for Safari"|translate("s18")}}</a>
       <a class="install-button" href="https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" id="install-yandex-browser" onclick="chrome.webstore.install(); return false;">{{"Install for Yandex Browser"|translate("s19")}}</a>
+      <div id="other-browsers">{{"Download Adblock Plus for another browser:"|translate("other-browsers")}}</div>
       <ul>
         <li>
           <a class="sprite" href="firefox" id="platform-firefox" title="{{"Adblock Plus for Firefox"|translate("s20")}}"></a>
@@ -101,6 +119,9 @@
         <li>
           <a class="sprite" href="maxthon" id="platform-maxthon" title="{{"Adblock Plus for Maxthon"|translate("s27")}}"></a>
         </li>
+        <li>
+          <a class="sprite" href="edge" id="platform-edge" title="{{"Adblock Plus for Microsoft Edge"|translate("abp-microsoft-edge")}}"></a>
+        </li>
       </ul>
     </div>
   </section>
@@ -124,6 +145,7 @@
   </div>
   <iframe frameborder="0" height="285" id="video" itemprop="video" src="//www.youtube-nocookie.com/embed/pVYtzF5SemU?html5=1&amp;autohide=1&amp;enablejsapi=1&amp;controls=2&amp;fs=1&amp;modestbranding=1&amp;rel=0&amp;showinfo=0&amp;theme=light" width="520"></iframe>
   <img height="305" id="maxthon-instruction" src="/img/maxthon-instruction.png" width="540">
+  <img id="edge-teaser" src="/img/edge_teaser.png">
 </div>
 
 <div id="key-facts">
@@ -189,6 +211,9 @@
       <button id="more-maxthon" onclick="showTab(this);return false;">
         {{"Maxthon"|translate("s59")}}
       </button>
+      <button id="more-edge" onclick="showTab(this);return false;">
+        {{"Microsoft Edge"|translate("microsoft-edge")}}
+      </button>
     </div>
 
     <div class="more-tab" id="tab-firefox">
@@ -341,6 +366,13 @@
         {{"Different from being as an extension on other browsers, Adblock Plus has been integrated by default for Maxthon users, and as an opt-in option for Chinese users. Are you fed up with advertisers infringing on your browsing experience? Simply install Maxthon Cloud Browser and all annoying ads will be automatically blocked from the internet. Blinking banners, popups, video commercials on YouTube and Facebook ads: Maxthon Cloud Browser with Adblock Plus integrated will automatically remove any unwanted ad from every website you visit. Want more? You can easily activate additional privacy and security features such as tracking and malware protection."|translate("s98")}}
       </p>
     </div>
+    <div class="more-tab" id="tab-edge">
+      <h2>{{"Be notified when Adblock Plus for Microsoft Edge is available!"|translate("abp-for-edge-be-notified")}}</h2>
+
+      <p>
+        {{"Microsoft Edge <a href='https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6508820-javascript-browser-extensions'>does not yet support extensions</a>. However, you can be sure that a version of Adblock Plus for Microsoft Edge will be released as soon as possible. Enter your email in the field above to receive a notification when Adblock Plus for Microsoft Edge is available. While you're waiting, you may want to try the latest version of Adblock Plus for Internet Explorer."|translate("ms-edge-description")}}
+      </p>
+    </div>
   </div>
 </section>