Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: mobile/android/base/BrowserApp.java

Issue 29324521: Issue 2930 - Re-enable and adapt about:feedback (Closed)
Patch Set: Created Aug. 23, 2015, 6:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mobile/android/app/mobile.js ('k') | mobile/android/chrome/content/aboutFeedback.xhtml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*- 1 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
2 * This Source Code Form is subject to the terms of the Mozilla Public 2 * This Source Code Form is subject to the terms of the Mozilla Public
3 * License, v. 2.0. If a copy of the MPL was not distributed with this 3 * License, v. 2.0. If a copy of the MPL was not distributed with this
4 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 4 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
5 5
6 package org.mozilla.gecko; 6 package org.mozilla.gecko;
7 7
8 import org.mozilla.gecko.AppConstants.Versions; 8 import org.mozilla.gecko.AppConstants.Versions;
9 import org.mozilla.gecko.DynamicToolbar.PinReason; 9 import org.mozilla.gecko.DynamicToolbar.PinReason;
10 import org.mozilla.gecko.DynamicToolbar.VisibilityTransition; 10 import org.mozilla.gecko.DynamicToolbar.VisibilityTransition;
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 @Override 225 @Override
226 public float getInterpolation(float t) { 226 public float getInterpolation(float t) {
227 t -= 1.0f; 227 t -= 1.0f;
228 return t * t * t * t * t + 1.0f; 228 return t * t * t * t * t + 1.0f;
229 } 229 }
230 }; 230 };
231 231
232 private FindInPageBar mFindInPageBar; 232 private FindInPageBar mFindInPageBar;
233 private MediaCastingBar mMediaCastingBar; 233 private MediaCastingBar mMediaCastingBar;
234 234
235 // Don't show about:feedback automatically in Adblock Browser, see 235 // We'll ask for feedback after the user launches the app this many times.
236 // https://issues.adblockplus.org/ticket/2521 236 // Mozilla did this after 15 times. In Adblock Browser, we prefer to do it
237 private static final int FEEDBACK_LAUNCH_COUNT = 0; 237 // a bit earlier, see: https://issues.adblockplus.org/ticket/2930.
238 private static final int FEEDBACK_LAUNCH_COUNT = 5;
238 239
239 // Stored value of the toolbar height, so we know when it's changed. 240 // Stored value of the toolbar height, so we know when it's changed.
240 private int mToolbarHeight; 241 private int mToolbarHeight;
241 242
242 // Stored value of whether the last metrics change allowed for toolbar 243 // Stored value of whether the last metrics change allowed for toolbar
243 // scrolling. 244 // scrolling.
244 private boolean mDynamicToolbarCanScroll; 245 private boolean mDynamicToolbarCanScroll;
245 246
246 private SharedPreferencesHelper mSharedPreferencesHelper; 247 private SharedPreferencesHelper mSharedPreferencesHelper;
247 248
(...skipping 3543 matching lines...) Expand 10 before | Expand all | Expand 10 after
3791 dispatcher, 3792 dispatcher,
3792 osLocale, 3793 osLocale,
3793 appLocale, 3794 appLocale,
3794 previousSession); 3795 previousSession);
3795 } 3796 }
3796 3797
3797 public static interface Refreshable { 3798 public static interface Refreshable {
3798 public void refresh(); 3799 public void refresh();
3799 } 3800 }
3800 } 3801 }
OLDNEW
« no previous file with comments | « mobile/android/app/mobile.js ('k') | mobile/android/chrome/content/aboutFeedback.xhtml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld