Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterListener.js

Issue 29324599: Issue 2392/2393 - Created container for CSS property filters (Closed)
Left Patch Set: Created Aug. 25, 2015, 3:35 p.m.
Right Patch Set: Rebased and addressed comments Created Nov. 25, 2015, 11:12 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« lib/cssRules.js ('K') | « lib/filterClasses.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 10 matching lines...) Expand all
21 21
22 Cu.import("resource://gre/modules/XPCOMUtils.jsm"); 22 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
23 Cu.import("resource://gre/modules/Services.jsm"); 23 Cu.import("resource://gre/modules/Services.jsm");
24 24
25 let {FilterStorage} = require("filterStorage"); 25 let {FilterStorage} = require("filterStorage");
26 let {FilterNotifier} = require("filterNotifier"); 26 let {FilterNotifier} = require("filterNotifier");
27 let {ElemHide} = require("elemHide"); 27 let {ElemHide} = require("elemHide");
28 let {CSSRules} = require("cssRules"); 28 let {CSSRules} = require("cssRules");
29 let {defaultMatcher} = require("matcher"); 29 let {defaultMatcher} = require("matcher");
30 let {ActiveFilter, RegExpFilter, ElemHideBase, CSSPropertyFilter} = 30 let {ActiveFilter, RegExpFilter, ElemHideBase, CSSPropertyFilter} =
31 require("filterClasses"); 31 require("filterClasses");
Wladimir Palant 2015/11/05 12:46:19 Nit: While I couldn't find anything in our style g
Thomas Greiner 2015/11/25 11:20:00 Done. I looked through our code and unfortunately,
32 let {Prefs} = require("prefs"); 32 let {Prefs} = require("prefs");
33 33
34 /** 34 /**
35 * Value of the FilterListener.batchMode property. 35 * Value of the FilterListener.batchMode property.
36 * @type Boolean 36 * @type Boolean
37 */ 37 */
38 let batchMode = false; 38 let batchMode = false;
39 39
40 /** 40 /**
41 * Increases on filter changes, filters will be saved if it exceeds 1. 41 * Increases on filter changes, filters will be saved if it exceeds 1.
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 ElemHide.clear(); 278 ElemHide.clear();
279 CSSRules.clear(); 279 CSSRules.clear();
280 for (let subscription of FilterStorage.subscriptions) 280 for (let subscription of FilterStorage.subscriptions)
281 if (!subscription.disabled) 281 if (!subscription.disabled)
282 subscription.filters.forEach(addFilter); 282 subscription.filters.forEach(addFilter);
283 flushElemHide(); 283 flushElemHide();
284 } 284 }
285 else if (action == "save") 285 else if (action == "save")
286 isDirty = 0; 286 isDirty = 0;
287 } 287 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld