Issue 2394 - Added unit tests for CSS property filters

chrome/content/tests/filterListener.js

 (function()
 {
   module("Filter listener", {
     setup: function()
     {
       prepareFilterComponents.call(this, true);
       preparePrefs.call(this);
 
       FilterStorage.addSubscription(Subscription.fromURL("~fl~"));
       FilterStorage.addSubscription(Subscription.fromURL("~wl~"));
@@ skipping 38 matching lines @@
     result.elemhideexception = [];
     for (let selector in ElemHideGlobal.exceptions)
     {
       let list = ElemHideGlobal.exceptions[selector];
       for (let exception of list)
         result.elemhideexception.push(exception.text);
     }
 
     let CSSRulesGlobal = getModuleGlobal("cssRules");
     result.cssrule = [];
-    for (let key in CSSRulesGlobal.filters)
-    {
-      let filter = Filter.fromText(key);
-      result.cssrule.push(filter.text);

[Wladimir Palant, 2015/12/04 13:09:48]

This is an unnecessary roundtrip - result.cssrule.push(key) will do.

[Thomas Greiner, 2015/12/07 17:29:26]

Done.

-    }
+    for (let filterText in CSSRulesGlobal.filters)
+      result.cssrule.push(filterText);
 
     let types = ["blacklist", "whitelist", "elemhide", "elemhideexception",
       "cssrule"];
     for (let type of types)
       if (!(type in expected))
         expected[type] = [];
 
     deepEqual(result, expected, text);
   }
 
@@ skipping 200 matching lines @@
     subscription3.disabled = true;
     checkKnownFilters("disable exception rules", {blacklist: [filter1.text, filter3.text], whitelist: [filter2.text]});
 
     FilterStorage.removeSubscription(subscription4);
     checkKnownFilters("remove subscription from the list", {blacklist: [filter1.text]});
 
     subscription3.disabled = false;
     checkKnownFilters("enable exception rules", {blacklist: [filter1.text], whitelist: [filter2.text]});
   });
 })();