Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/firstRun.css

Issue 29326238: Issue 3031 - Add Adblock Browser section to First Run Page (Closed)
Left Patch Set: Addressed Thomas comments Created Sept. 16, 2015, 11:07 a.m.
Right Patch Set: Reverted back to table-cell Created Sept. 16, 2015, 2:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « skin/abb-logo.png ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 padding: 40px 0px; 149 padding: 40px 0px;
150 display: table; 150 display: table;
151 } 151 }
152 152
153 #general > div 153 #general > div
154 { 154 {
155 display: table-cell; 155 display: table-cell;
156 width: 50%; 156 width: 50%;
157 vertical-align: top; 157 vertical-align: top;
158 padding: 0px 50px; 158 padding: 0px 50px;
159 } 159 border: dashed 0 #969085;
160 160 -webkit-border-start-width: 1px;
161 #general > div:not(:first-child) 161 -moz-border-start-width: 1px;
162 { 162 border-inline-start-width: 1px;
163 border-left: dashed 1px #969085; 163 }
164 } 164
165 165 #general > div:first-child
166 html[dir="rtl"] #general > div:not(:first-child) 166 {
167 { 167 border: none;
168 border-left: none;
169 border-right: dashed 1px #969085;
170 } 168 }
171 169
172 #acceptable-ads-block h2 170 #acceptable-ads-block h2
173 { 171 {
174 margin-bottom: 34px; 172 margin-bottom: 34px;
175 } 173 }
176 174
177 #abb-promotion-block:lang(fr) 175 #abb-promotion-block:lang(fr)
178 { 176 {
179 display: none; 177 display: none;
(...skipping 12 matching lines...) Expand all
192 190
193 #abb-promotion-block a 191 #abb-promotion-block a
194 { 192 {
195 border: solid 1px #446a96; 193 border: solid 1px #446a96;
196 border-radius: 5px; 194 border-radius: 5px;
197 display: inline-block; 195 display: inline-block;
198 padding: 6px 16px; 196 padding: 6px 16px;
199 background: -webkit-linear-gradient(bottom, #294e76, #6b92be); 197 background: -webkit-linear-gradient(bottom, #294e76, #6b92be);
200 background: linear-gradient(to top, #294e76, #6b92be); 198 background: linear-gradient(to top, #294e76, #6b92be);
201 text-decoration: none; 199 text-decoration: none;
202 text-align: left; 200 text-align: start;
Thomas Greiner 2015/09/16 12:28:12 What about RTL languages?
Sebastian Noack 2015/09/16 12:32:33 Well spotted. It should be |text-algin: start|.
saroyanm 2015/09/16 12:47:20 Done.
203 } 201 }
204 202
205 #abb-promotion-block a > div 203 #abb-promotion-block a > div
206 { 204 {
207 display: inline-block; 205 display: table-cell;
208 vertical-align: middle; 206 vertical-align: middle;
209 padding: 6px; 207 padding: 6px;
210 } 208 }
211 209
212 #abb-promotion-block .title 210 #abb-promotion-block .title
213 { 211 {
214 font-size: 21px; 212 font-size: 21px;
215 color: #ffffff; 213 color: #ffffff;
216 font-weight: bold; 214 font-weight: bold;
217 } 215 }
(...skipping 12 matching lines...) Expand all
230 #abb-promotion-block a:active 228 #abb-promotion-block a:active
231 { 229 {
232 box-shadow: 0px 0px 5px 1px #5D5D5D; 230 box-shadow: 0px 0px 5px 1px #5D5D5D;
233 } 231 }
234 232
235 @media (max-width: 960px) 233 @media (max-width: 960px)
236 { 234 {
237 #general 235 #general
238 { 236 {
239 display: block; 237 display: block;
240 }
241
242 #content #general > div:not(:first-child)
saroyanm 2015/09/16 11:08:43 I'm using #content for css Specificity, becuase ht
243 {
244 border: none;
245 }
246
247 #content #general > div:not(:first-child)
Thomas Greiner 2015/09/16 12:28:12 You're using the same selector as the block above
Sebastian Noack 2015/09/16 12:32:33 This will be redundant, if you use the CSS I sugge
248 {
249 border-top: dashed 1px #969085;
250 } 238 }
251 239
252 #general > div 240 #general > div
253 { 241 {
254 display: block; 242 display: block;
255 width: auto; 243 width: auto;
256 padding: 10px 0px; 244 padding: 10px 0px;
257 margin: 0px 50px; 245 margin: 0px 50px;
246 border-width: 1px 0 0;
258 } 247 }
259 } 248 }
260 249
261 section > p 250 section > p
262 { 251 {
263 margin: 15px 0 0 0; 252 margin: 15px 0 0 0;
264 } 253 }
265 254
266 #logo 255 #logo
267 { 256 {
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 background-image: url(donate.png); 694 background-image: url(donate.png);
706 background-repeat: repeat-x; 695 background-repeat: repeat-x;
707 } 696 }
708 697
709 footer 698 footer
710 { 699 {
711 margin: 0 auto 30px; 700 margin: 0 auto 30px;
712 max-width: 960px; 701 max-width: 960px;
713 text-align: center; 702 text-align: center;
714 } 703 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld