Issue 2864 - Introduce class logstash

modules/logstash/manifests/init.pp

 # == Class: logstash
 #
 # Manage Logstash (https://logstash.net/) installations via APT.
 #
 # Please refer to the online documentation at Elastic for more information
 # on the logstash software, it's usage and configuration options:
 #
 # https://www.elastic.co/guide/en/logstash/current/index.html
 #
 # === Parameters:
 #
 # [*contrib*]
 #   Whether to realize Package['logstash-contrib'].
 #
 # [*ensure*]
 #   Either 'present'/'stopped', 'running'/'started', or 'absent'/'purged'.
 #   Note that Service['logstash'] is only realized implicitly when $ensure
 #   is neither 'absent' nor 'purged'.
 #
 # [*pipelines*]
 #   A hash to setup logstash::pipeline {$name: $parameter} resources.
 #
 # [*version*]
-#   The http://packages.elasticsearch.org/logstash/%s/debian $version.
+#   The https://packages.elasticsearch.org/logstash/%s/debian $version.
 #
 # === Examples:
 #
 #   class {'logstash':
 #     contrib => true,
 #     pipelines => {
 #       'example' => {
 #         # see type logstash::pipeline for a parameter reference
 #       },
 #     },
@@ skipping 13 matching lines @@
 
   apt::key {'logstash':
     ensure => $ensure_file,
     key => 'D88E42B4',
     key_content => template('logstash/elastic-logstash-gpg-key.erb'),
   }
 
   apt::source {'logstash':
     ensure => $ensure_file,
     include_src => false,
-    location => "http://packages.elasticsearch.org/logstash/$version/debian",

[Felix Dahlke, 2015/10/07 10:46:32]

Can we use HTTPS?

[mathias, 2015/10/20 13:03:33]

Yes we can.

+    location => "https://packages.elasticsearch.org/logstash/$version/debian",
     release => 'stable',
     require => Apt::Key['logstash'],
   }
 
   package {'logstash':
     ensure => $ensure ? {
       /^(absent|purged)$/ => $ensure,
       default => 'present',
     },
     require => Apt::Source['logstash'],
@@ skipping 14 matching lines @@
       default => true,
     },
     ensure => $ensure ? {
       /^(running|started)$/ => 'running',
       default => 'stopped',
     },
     hasrestart => true,
     require => Package['logstash'],
   }
 
   file {'/usr/local/bin/logstash':

[Felix Dahlke, 2015/10/07 10:46:32]

Would a symlink do?

If not: AFAIK it's a sort of convention to not add ".sh" to executable scripts.
We always do that with our Python scripts so they're runnable on Windows
(although many of them never need to run there), but I guess there's no reason
to do that with a shell script. No strong opinion however, just a remark.

[mathias, 2015/10/20 13:03:33]

No, a symbolic link won't do. The /opt/logstash/bin/logstash script under the
hood uses the path of $0 as-is, in order to determine the location of additional
resources.

[Felix Dahlke, 2015/10/30 09:43:10]

Acknowledged.

     ensure => $ensure_file,
     mode => 0755,
     source => 'puppet:///modules/logstash/logstash.sh',
     require => Package['logstash'],
   }
 
   if $contrib {
     realize(Package['logstash-contrib'])
   }
 
   if $ensure !~ /^(absent|purged)$/ {
     realize(Service['logstash'])
   }
 
   create_resources('logstash::pipeline', $pipelines)
 }