Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: modules/filtermaster/manifests/repo_download.pp

Issue 29329059: Issue 3196 - Correct misuse of $alias metaparameter (Closed)
Patch Set: Created Oct. 13, 2015, 9:07 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | modules/filtermaster/templates/sitescripts.ini.erb » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # == Type: filtermaster::repo_download 1 # == Type: filtermaster::repo_download
2 # 2 #
3 # Manage filter list download source repositories for aggregation. 3 # Manage filter list download source repositories for aggregation.
4 # 4 #
5 # === Parameters: 5 # === Parameters:
6 # 6 #
7 # [*alias*] 7 # [*target*]
8 # An optional alias for use as the download resource name, allows for 8 # An optional alias for use as the download resource name, allows for
9 # repositories with different names. Note that this option is recognized 9 # repositories with different names. Note that this option is recognized
10 # only when setup via hiera('filtermaster::repo_downloads')! 10 # only when setup via hiera('filtermaster::repo_downloads')!
11 # 11 #
12 # === Examples: 12 # === Examples:
13 # 13 #
14 # filtermaster::repo_download {'exceptionrules': 14 # filtermaster::repo_download {'exceptionrules':
15 # alias => 'exceptions', 15 # alias => 'exceptions',
16 # } 16 # }
17 # 17 #
18 define filtermaster::repo_download ( 18 define filtermaster::repo_download (
19 $alias = $title, 19 $target = $title,
20 ) { 20 ) {
21 21
22 $directory = "/home/rsync/subscription/$title" 22 $directory = "/home/rsync/subscription/$title"
23 $repository = "https://hg.adblockplus.org/$title" 23 $repository = "https://hg.adblockplus.org/$title"
24 24
25 ensure_packages(['mercurial']) 25 ensure_packages(['mercurial'])
26 26
27 exec {"filtermaster::repo_download#$title": 27 exec {"filtermaster::repo_download#$title":
28 command => shellquote('hg', 'clone', $repository, $directory), 28 command => shellquote('hg', 'clone', $repository, $directory),
29 onlyif => shellquote('test', '!', '-d', $directory), 29 onlyif => shellquote('test', '!', '-d', $directory),
30 path => ['/usr/local/bin', '/usr/bin', '/bin'], 30 path => ['/usr/local/bin', '/usr/bin', '/bin'],
31 require => Package['mercurial'], 31 require => Package['mercurial'],
32 timeout => 0, 32 timeout => 0,
33 user => 'rsync', 33 user => 'rsync',
34 } 34 }
35 } 35 }
OLDNEW
« no previous file with comments | « no previous file | modules/filtermaster/templates/sitescripts.ini.erb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld