Issue 3208 - Consider private browsing in contentPolicy module rather than filterStorage

lib/contentPolicy.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 127 matching lines @@
       let url = getWindowLocation(wnd);
       let index = url.indexOf("#");
       if (index >= 0)
         url = url.substring(0, index);
 
       return url;
     }
 
     function addHit(match)
     {
-      if (!PrivateBrowsingUtils.isWindowPrivate(wnd))

[Thomas Greiner, 2015/11/02 17:29:23]

I'm wondering whether `wnd` here could potentially be of type `nsIDOMWindow` as
opposed to `nsIDOMChromeWindow` (which is what `isWindowPrivate` expects) since
that's not explicitly stated at
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interfa....

Therefore, we may need to use `isBrowserPrivate` instead as recommended at
http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/PrivateBrowsing....

[Wladimir Palant, 2015/11/02 18:49:22]

Ouch, I overlooked the "Chrome" part, and documentation is outdated of course.
While this call works, the warning isn't intended of course.

I fixed this but the call here doesn't really matter - it is being removed a few
commits later. The call that will stay has been pushed already, I'll fix it in
https://codereview.adblockplus.org/29329554/.

+      if (!PrivateBrowsingUtils.isContentWindowPrivate(wnd))
         FilterStorage.increaseHitCount(match);
     }
 
     if (!match && Prefs.enabled)
     {
       let testWnd = wnd;
       let testSitekey = sitekey;
       let testSitekeyWnd = sitekeyWnd;
       let parentWndLocation = cleanWindowLocation(testWnd);
       while (true)
@@ skipping 519 matching lines @@
   if (!wnd || wnd.closed)
     return;
 
   if (entry.type == "OBJECT")
   {
     node.removeEventListener("mouseover", objectMouseEventHander, true);
     node.removeEventListener("mouseout", objectMouseEventHander, true);
   }
   Policy.processNode(wnd, node, entry.type, entry.location, true);
 }